Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 1974543002: DevTools: do not pro-actively query all StyleSheets for their content. (Closed)

Created:
4 years, 7 months ago by lushnikov
Modified:
4 years, 7 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not pro-actively query all StyleSheets for their content. Due to a programmatic error in crrev.com/1954423002, we currently query all the stylesheets for their content. This patch fixes this behavior and adds a test to ensure this will not happen. BUG=610061 R=dgozman, pfeldman Committed: https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6 Cr-Commit-Position: refs/heads/master@{#393025}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -25 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/search/search-in-static.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles/original-content-provider.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles/original-content-provider-expected.txt View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-panel.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-sorting.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/switch-file.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code-display-name.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/sources-panel-extension-names.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js View 3 chunks +17 lines, -5 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/ASTSourceMap.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
lushnikov
please, take a look!
4 years, 7 months ago (2016-05-11 17:53:35 UTC) #1
dgozman
lgtm https://codereview.chromium.org/1974543002/diff/1/third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js File third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js (right): https://codereview.chromium.org/1974543002/diff/1/third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js#newcode27 third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js:27: var lazyContent = () => Promise.resolve(content); This looks ...
4 years, 7 months ago (2016-05-11 18:09:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974543002/1
4 years, 7 months ago (2016-05-11 18:10:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 19:28:57 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 19:31:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6
Cr-Commit-Position: refs/heads/master@{#393025}

Powered by Google App Engine
This is Rietveld 408576698