Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1974533003: [Autofill] Don't record use of a profile after a merge. (Closed)

Created:
4 years, 7 months ago by sebsg
Modified:
4 years, 7 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Since the use_count and use_date of new profiles were changed to 1 and Now() respectively (were 0 and base::Time), there is no need to record the use of a newly merged profile. The merging logic will have set the usage statistics to the expected values. BUG=611223 TEST=PersonalDataManagerTest Committed: https://crrev.com/f25a299b4ae5855530c83dfcf7c4c6d854d533c8 Cr-Commit-Position: refs/heads/master@{#393344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -6 lines) Patch
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 2 chunks +47 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sebsg
Hi Math could you please take a look? Thanks!
4 years, 7 months ago (2016-05-11 22:45:34 UTC) #5
Mathieu
lgtm
4 years, 7 months ago (2016-05-12 20:29:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974533003/20001
4 years, 7 months ago (2016-05-12 20:35:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-12 20:41:00 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 20:41:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f25a299b4ae5855530c83dfcf7c4c6d854d533c8
Cr-Commit-Position: refs/heads/master@{#393344}

Powered by Google App Engine
This is Rietveld 408576698