Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 1974533002: Faster dispatch of integer operations on double. (Closed)

Created:
4 years, 7 months ago by regis
Modified:
4 years, 7 months ago
Reviewers:
rmacnak, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove extra spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M runtime/lib/double.dart View 1 1 chunk +8 lines, -8 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
This probably does not make a big difference, but the additional call is not necessary.
4 years, 7 months ago (2016-05-11 17:48:56 UTC) #2
Ivan Posva
LGTM -ip
4 years, 7 months ago (2016-05-12 23:22:58 UTC) #3
regis
4 years, 7 months ago (2016-05-12 23:54:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
845a447f9dbd193321f6374c7ec773203cc28679 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698