Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 197453002: Support 3 channels for audio input. (Closed)

Created:
6 years, 9 months ago by Henrik Grunell
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, tommi (sloooow) - chröme
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Cleanup and rebase. #

Patch Set 4 : Removed code for changing to keyboard mic layout #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M content/renderer/media/webrtc_audio_capturer.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/audio_input_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_manager_base.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Henrik Grunell
Shijing, can you take a look? Have I missed something? I have tested with Linux/PulseAudio ...
6 years, 8 months ago (2014-04-25 08:52:28 UTC) #1
Henrik Grunell
On 2014/04/25 08:52:28, Henrik Grunell wrote: > Shijing, can you take a look? Have I ...
6 years, 8 months ago (2014-04-25 08:57:12 UTC) #2
Henrik Grunell
On 2014/04/25 08:57:12, Henrik Grunell wrote: > On 2014/04/25 08:52:28, Henrik Grunell wrote: > > ...
6 years, 8 months ago (2014-04-25 10:39:31 UTC) #3
no longer working on chromium
lgtm
6 years, 8 months ago (2014-04-25 11:24:57 UTC) #4
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 7 months ago (2014-04-29 08:42:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/197453002/80001
6 years, 7 months ago (2014-04-29 08:43:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 09:16:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-29 09:16:19 UTC) #8
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 7 months ago (2014-04-29 09:30:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/197453002/80001
6 years, 7 months ago (2014-04-29 09:31:33 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 11:29:59 UTC) #11
Message was sent while issue was closed.
Change committed as 266849

Powered by Google App Engine
This is Rietveld 408576698