Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1529)

Unified Diff: components/ntp_snippets/ntp_snippets_fetcher.h

Issue 1974483002: Allow getting _only_ personalized snippets for NTP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: After code review #4 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/ntp_snippets_fetcher.h
diff --git a/components/ntp_snippets/ntp_snippets_fetcher.h b/components/ntp_snippets/ntp_snippets_fetcher.h
index 533f557d4981371ece78766c01950792cede9387..b3cd393f8299607eef4b1c212d064b08e861c812 100644
--- a/components/ntp_snippets/ntp_snippets_fetcher.h
+++ b/components/ntp_snippets/ntp_snippets_fetcher.h
@@ -52,7 +52,8 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
base::Callback<void(OptionalSnippets snippets)>;
// Enumeration listing all possible outcomes for fetch attempts. Used for UMA
- // histograms, so do not change existing values.
+ // histograms, so do not change existing values. Insert new values at the end,
+ // and update the histogram definition.
enum class FetchResult {
SUCCESS,
EMPTY_HOSTS,
@@ -60,6 +61,7 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
HTTP_ERROR,
JSON_PARSE_ERROR,
INVALID_SNIPPET_CONTENT_ERROR,
+ OAUTH_TOKEN_ERROR,
RESULT_MAX
};
@@ -99,7 +101,7 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
}
private:
- enum class Variant { kRestrictedPersonalized, kRestricted, kPersonalized };
+ enum class Personalization { kPersonal, kNonPersonal, kBoth };
void FetchSnippetsImpl(const GURL& url,
const std::string& auth_header,
@@ -163,8 +165,10 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
// Flag for picking the right (stable/non-stable) API key for Chrome Reader.
bool is_stable_channel_;
- // The variant of the fetching to use.
- Variant variant_;
+ // The variant of the fetching to use, loaded from variation parameters.
+ Personalization personalization_;
+ // Should we apply host restriction? It is loaded from variation parameters.
+ bool use_host_restriction_;
// Allow for an injectable tick clock for testing.
std::unique_ptr<base::TickClock> tick_clock_;
« no previous file with comments | « no previous file | components/ntp_snippets/ntp_snippets_fetcher.cc » ('j') | components/ntp_snippets/ntp_snippets_fetcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698