Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1974453003:
Improve the toolchains-hash calculation. (Closed)
|
Created:
4 years, 7 months ago by Sébastien Marchand Modified:
4 years, 5 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionImprove the toolchains-hash calculation.
I often ends up with a corrupt toolchain because I've used Windbg and there's now a bunch of PDB files in win_sdk/Debuggers/sym/... , I think that it's safe to ignore these files (the original package doesn't contain any of these files).
It's also useful to have more details about which files are missing and or which ones shouldn't be here when we get an invalid toolchain hash.
Finally, if you the hash of a toolchain doesn't correspond to the name of its root directory then it should be removed.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300557
Patch Set 1 #
Total comments: 6
Patch Set 2 : Address Scott's comments. #
Total comments: 5
Messages
Total messages: 27 (7 generated)
Description was changed from ========== Improve the toolchains-hash calculation. ========== to ========== Improve the toolchains-hash calculation. I often ends up with a corrupt toolchain because I've used Windbg and there's now a bunch of PDB files in win_sdk/Debuggers/sym/... , I think that it's safe to ignore these files (the original package doesn't contain any of these files). It's also useful to have more details about which files are missing and or which ones shouldn't be here when we get an invalid toolchain hash. Finally, if you the hash of a toolchain doesn't correspond to the name of its root directory then it should be removed. ==========
sebmarchand@chromium.org changed reviewers: + scottmg@chromium.org
sebmarchand@chromium.org changed reviewers: + brucedawson@chromium.org
PTAL.
https://codereview.chromium.org/1974453003/diff/1/win_toolchain/get_toolchain... File win_toolchain/get_toolchain_if_necessary.py (right): https://codereview.chromium.org/1974453003/diff/1/win_toolchain/get_toolchain... win_toolchain/get_toolchain_if_necessary.py:79: ignored_directories = ['wer\\reportqueue', Does this intentionally not have a trailing \? https://codereview.chromium.org/1974453003/diff/1/win_toolchain/get_toolchain... win_toolchain/get_toolchain_if_necessary.py:84: for f in paths: maybe p instead of f since f is used above https://codereview.chromium.org/1974453003/diff/1/win_toolchain/get_toolchain... win_toolchain/get_toolchain_if_necessary.py:167: def CalculateToolchainHashes(root, remove_corrupt_toolchains): This new argument doesn't seem to be used.
Patchset #2 (id:20001) has been deleted
Thanks, PTAnL. https://codereview.chromium.org/1974453003/diff/1/win_toolchain/get_toolchain... File win_toolchain/get_toolchain_if_necessary.py (right): https://codereview.chromium.org/1974453003/diff/1/win_toolchain/get_toolchain... win_toolchain/get_toolchain_if_necessary.py:79: ignored_directories = ['wer\\reportqueue', On 2016/05/11 19:21:36, scottmg wrote: > Does this intentionally not have a trailing \? I don't know if reportqueue is the name of the directory containing the ReportQueue entries or if it's just the beginning of the filenames (e.g. wer\\reportqueue_foo.bar), so I just didn't changed it. https://codereview.chromium.org/1974453003/diff/1/win_toolchain/get_toolchain... win_toolchain/get_toolchain_if_necessary.py:84: for f in paths: On 2016/05/11 19:21:36, scottmg wrote: > maybe p instead of f since f is used above Done. https://codereview.chromium.org/1974453003/diff/1/win_toolchain/get_toolchain... win_toolchain/get_toolchain_if_necessary.py:167: def CalculateToolchainHashes(root, remove_corrupt_toolchains): On 2016/05/11 19:21:36, scottmg wrote: > This new argument doesn't seem to be used. Oops. Fixed.
lgtm
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974453003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974453003/40001
Message was sent while issue was closed.
Description was changed from ========== Improve the toolchains-hash calculation. I often ends up with a corrupt toolchain because I've used Windbg and there's now a bunch of PDB files in win_sdk/Debuggers/sym/... , I think that it's safe to ignore these files (the original package doesn't contain any of these files). It's also useful to have more details about which files are missing and or which ones shouldn't be here when we get an invalid toolchain hash. Finally, if you the hash of a toolchain doesn't correspond to the name of its root directory then it should be removed. ========== to ========== Improve the toolchains-hash calculation. I often ends up with a corrupt toolchain because I've used Windbg and there's now a bunch of PDB files in win_sdk/Debuggers/sym/... , I think that it's safe to ignore these files (the original package doesn't contain any of these files). It's also useful to have more details about which files are missing and or which ones shouldn't be here when we get an invalid toolchain hash. Finally, if you the hash of a toolchain doesn't correspond to the name of its root directory then it should be removed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300557 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300557
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + thakis@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... File win_toolchain/get_toolchain_if_necessary.py (right): https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... win_toolchain/get_toolchain_if_necessary.py:81: 'win_sdk\\debuggers\\x64\\sym\\'] this won't work on non-windows. it looks like this currently has no ill effects though.
Message was sent while issue was closed.
https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... File win_toolchain/get_toolchain_if_necessary.py (right): https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... win_toolchain/get_toolchain_if_necessary.py:81: 'win_sdk\\debuggers\\x64\\sym\\'] On 2016/05/27 14:45:57, Nico (away until Tue May 31) wrote: > this won't work on non-windows. it looks like this currently has no ill effects > though. These files get created by Windbg/WER, so they shouldn't exist on a non-Windows system ? (unless you use Windbg with Wine ? Not sure if it works)
Message was sent while issue was closed.
On 2016/05/27 15:16:22, Sébastien Marchand wrote: > https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... > File win_toolchain/get_toolchain_if_necessary.py (right): > > https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... > win_toolchain/get_toolchain_if_necessary.py:81: > 'win_sdk\\debuggers\\x64\\sym\\'] > On 2016/05/27 14:45:57, Nico (away until Tue May 31) wrote: > > this won't work on non-windows. it looks like this currently has no ill > effects > > though. > > These files get created by Windbg/WER, so they shouldn't exist on a non-Windows > system ? (unless you use Windbg with Wine ? Not sure if it works) Ah, that's a good point, thanks :-) Maybe there could be a comment pointing this out.
Message was sent while issue was closed.
https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... File win_toolchain/get_toolchain_if_necessary.py (right): https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... win_toolchain/get_toolchain_if_necessary.py:133: # missing. On my windows box, this just spent several minutes printing many screenfulls of filenames. I don't know if it was missing or extra files (the header scrolled off), but it looked like it printed every single filename. Maybe this should just say "N missing files, first 10 here". The current experience isn't so good.
Message was sent while issue was closed.
On 2016/06/22 15:09:11, Nico wrote: > https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... > File win_toolchain/get_toolchain_if_necessary.py (right): > > https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... > win_toolchain/get_toolchain_if_necessary.py:133: # missing. > On my windows box, this just spent several minutes printing many screenfulls of > filenames. I don't know if it was missing or extra files (the header scrolled > off), but it looked like it printed every single filename. Maybe this should > just say "N missing files, first 10 here". The current experience isn't so good. What was it printing? Did you unzip something funny into the directory?
Message was sent while issue was closed.
On 2016/06/22 17:49:01, scottmg wrote: > On 2016/06/22 15:09:11, Nico wrote: > > > https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... > > File win_toolchain/get_toolchain_if_necessary.py (right): > > > > > https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... > > win_toolchain/get_toolchain_if_necessary.py:133: # missing. > > On my windows box, this just spent several minutes printing many screenfulls > of > > filenames. I don't know if it was missing or extra files (the header scrolled > > off), but it looked like it printed every single filename. Maybe this should > > just say "N missing files, first 10 here". The current experience isn't so > good. > > What was it printing? Tabs followed by filenames. An excerpt: vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\locale\locale_update.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\locale\localeconv.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\locale\nlsdata.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\locale\setlocale.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\locale\wsetlocale.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\chsize.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\close.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\commit.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\creat.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\dup.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\dup2.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\eof.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\filelength.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\ioinit.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\isatty.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\locking.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\lseek.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\mktemp.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\open.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\osfinfo.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\read.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\setmode.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\tell.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\telli64.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\txtmode.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\umask.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\write.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbalnm.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbalph.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbbyte.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbdgt.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbgrph.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbknj.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismblgl.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismblwr.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbprn.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbpunc.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbsle.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbspc.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbupr.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbbtype.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbccpy.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbccpy_s.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbccpy_s_l.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbclen.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbclevel.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbctype.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbsbtype.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscat_s.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscat_s_l.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbschr.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscmp.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscoll.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscpy_s.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscpy_s_l.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscspn.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbsdec.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbsicmp.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbsicoll.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbsinc.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbslen.cpp vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbslen_s.cpp > Did you unzip something funny into the directory? Not that I remember (but I haven't used this box in over a week)
Message was sent while issue was closed.
Those are files that are supposed to be there, FWIW. So missing files presumably. I agree that that amount of spamming the console is counter productive.
Message was sent while issue was closed.
Sorry for that, I'll only display the 10 first extra/missing files !
Message was sent while issue was closed.
On 2016/06/22 17:50:55, Nico wrote: > On 2016/06/22 17:49:01, scottmg wrote: > > On 2016/06/22 15:09:11, Nico wrote: > > > > > > https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... > > > File win_toolchain/get_toolchain_if_necessary.py (right): > > > > > > > > > https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... > > > win_toolchain/get_toolchain_if_necessary.py:133: # missing. > > > On my windows box, this just spent several minutes printing many screenfulls > > of > > > filenames. I don't know if it was missing or extra files (the header > scrolled > > > off), but it looked like it printed every single filename. Maybe this should > > > just say "N missing files, first 10 here". The current experience isn't so > > good. > > > > What was it printing? > > Tabs followed by filenames. An excerpt: > > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\locale\locale_update.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\locale\localeconv.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\locale\nlsdata.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\locale\setlocale.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\locale\wsetlocale.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\chsize.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\close.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\commit.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\creat.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\dup.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\dup2.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\eof.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\filelength.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\ioinit.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\isatty.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\locking.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\lseek.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\mktemp.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\open.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\osfinfo.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\read.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\setmode.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\tell.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\telli64.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\txtmode.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\umask.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\lowio\write.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbalnm.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbalph.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbbyte.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbdgt.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbgrph.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbknj.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismblgl.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismblwr.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbprn.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbpunc.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbsle.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbspc.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\ismbupr.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbbtype.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbccpy.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbccpy_s.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbccpy_s_l.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbclen.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbclevel.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbctype.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbsbtype.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscat_s.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscat_s_l.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbschr.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscmp.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscoll.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscpy_s.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscpy_s_l.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbscspn.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbsdec.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbsicmp.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbsicoll.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbsinc.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbslen.cpp > > vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\win_sdk\Source\10.0.10586.0\ucrt\mbstring\mbslen_s.cpp > > > Did you unzip something funny into the directory? > > Not that I remember (but I haven't used this box in over a week) That's the current toolchain, so I have no idea why it's nuking that? Seb? (But yeah, switching to something with shorter output might be nice. Maybe it could log to a file if the actual list of files tends to be useful?)
Message was sent while issue was closed.
I don't think that we should log to a file, if you get more than 10 files missing then you'll probably want to nuke the toolchain and redownload it.
Message was sent while issue was closed.
FYI, this is fixed by https://codereview.chromium.org/2092753003/
Message was sent while issue was closed.
https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... File win_toolchain/get_toolchain_if_necessary.py (right): https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... win_toolchain/get_toolchain_if_necessary.py:175: if toolchain_hash != d: Do you really want to compare toolchain_hash and d here? On My linux box, I got several lines like Calculating hash of toolchain in vs_files/DIA SDK. Please wait... The hash of a version of the toolchain has an unexpected value (5b9fe12411cc48404db2dcdfdef641f1bc213804 instead of DIA SDK), removing it. It happened only once when an update was indeed necessary, but "5b9fe..." and "DIA SDK" look like strings with different types.
Message was sent while issue was closed.
https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... File win_toolchain/get_toolchain_if_necessary.py (right): https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... win_toolchain/get_toolchain_if_necessary.py:175: if toolchain_hash != d: On 2016/07/08 14:38:30, Nico wrote: > Do you really want to compare toolchain_hash and d here? On My linux box, I got > several lines like > > Calculating hash of toolchain in vs_files/DIA SDK. Please wait... > The hash of a version of the toolchain has an unexpected value > (5b9fe12411cc48404db2dcdfdef641f1bc213804 instead of DIA SDK), removing it. > > It happened only once when an update was indeed necessary, but "5b9fe..." and > "DIA SDK" look like strings with different types. It's not a bug, it's a feature :). In the past it wasn't possible to keep several versions of the toolchain at the same time, so the win_toolchain directory structure looked like this: win_toolchain/vs_files/DIA_SDK |win_sdk |... Now each version of the toolchain is kept in a different subdirectory: win_toolchain/vs_files/{hash}/DIA_SDK |win_sdk |... So the original copy of the toolchain (the one directly in vs_files/) will look corrupt and each of these directory will get removed. It should only happen once.
Message was sent while issue was closed.
Ah ok. Thanks for explaining! On Fri, Jul 8, 2016 at 10:44 AM, sebmarchand@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > > > https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... > File win_toolchain/get_toolchain_if_necessary.py (right): > > > https://codereview.chromium.org/1974453003/diff/40001/win_toolchain/get_toolc... > win_toolchain/get_toolchain_if_necessary.py:175: if toolchain_hash != d: > On 2016/07/08 14:38:30, Nico wrote: > > Do you really want to compare toolchain_hash and d here? On My linux > box, I got > > several lines like > > > > Calculating hash of toolchain in vs_files/DIA SDK. Please wait... > > The hash of a version of the toolchain has an unexpected value > > (5b9fe12411cc48404db2dcdfdef641f1bc213804 instead of DIA SDK), > removing it. > > > > It happened only once when an update was indeed necessary, but > "5b9fe..." and > > "DIA SDK" look like strings with different types. > > It's not a bug, it's a feature :). In the past it wasn't possible to > keep several versions of the toolchain at the same time, so the > win_toolchain directory structure looked like this: > > win_toolchain/vs_files/DIA_SDK > |win_sdk > |... > > Now each version of the toolchain is kept in a different subdirectory: > > win_toolchain/vs_files/{hash}/DIA_SDK > |win_sdk > |... > > So the original copy of the toolchain (the one directly in vs_files/) > will look corrupt and each of these directory will get removed. > > It should only happen once. > > https://codereview.chromium.org/1974453003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
