Create a public API around webkit::ppapi::PluginInstance and use it in chrome. After this, webkit/p…

chrome/renderer/pepper/ppb_pdf_impl.cc

Index: chrome/renderer/pepper/ppb_pdf_impl.cc
===================================================================
--- chrome/renderer/pepper/ppb_pdf_impl.cc	(revision 213350)
+++ chrome/renderer/pepper/ppb_pdf_impl.cc	(working copy)
@@ -136,7 +136,7 @@
   PluginInstance* instance = PluginInstance::Get(instance_id);
   if (!instance)
     return WebKit::WebElement();
-  return instance->container()->element();
+  return instance->GetContainer()->element();
 }
 
 printing::PrintWebViewHelper* GetPrintWebViewHelper(
@@ -289,30 +289,30 @@
   PluginInstance* instance = PluginInstance::Get(instance_id);
   if (!instance)
     return;
-  instance->render_view()->DidStartLoading();
+  instance->GetRenderView()->DidStartLoading();
 }
 
 void DidStopLoading(PP_Instance instance_id) {
   PluginInstance* instance = PluginInstance::Get(instance_id);
   if (!instance)
     return;
-  instance->render_view()->DidStopLoading();
+  instance->GetRenderView()->DidStopLoading();
 }
 
 void SetContentRestriction(PP_Instance instance_id, int restrictions) {
   PluginInstance* instance = PluginInstance::Get(instance_id);
   if (!instance)
     return;
-  instance->render_view()->Send(
+  instance->GetRenderView()->Send(
       new ChromeViewHostMsg_PDFUpdateContentRestrictions(
-          instance->render_view()->GetRoutingID(), restrictions));
+          instance->GetRenderView()->GetRoutingID(), restrictions));
 }
 
-void HistogramPDFPageCount(PP_Instance /*instance*/, int count) {
+void HistogramPDFPageCount(PP_Instance instance, int count) {

[scottmg, 2013/07/24 18:15:39]

is that going to cause a warning/break somewhere?

[jam, 2013/07/24 18:49:29]

nope, this is just code that doesn't follow the chrome conventions

   UMA_HISTOGRAM_COUNTS_10000("PDF.PageCount", count);
 }
 
-void UserMetricsRecordAction(PP_Instance /*instance*/, PP_Var action) {
+void UserMetricsRecordAction(PP_Instance instance, PP_Var action) {
   scoped_refptr<ppapi::StringVar> action_str(
       ppapi::StringVar::FromPPVar(action));
   if (action_str.get())
@@ -328,7 +328,7 @@
   if (!instance->IsFullPagePlugin())
     return;
 
-  WebView* view = instance->container()->element().document().frame()->view();
+  WebView* view = instance->GetContainer()->element().document().frame()->view();
   content::RenderView* render_view = content::RenderView::FromWebView(view);
   render_view->Send(new ChromeViewHostMsg_PDFHasUnsupportedFeature(
       render_view->GetRoutingID()));
@@ -338,9 +338,9 @@
   PluginInstance* instance = PluginInstance::Get(instance_id);
   if (!instance)
     return;
-  GURL url = instance->plugin_url();
+  GURL url = instance->GetPluginURL();
 
-  content::RenderView* render_view = instance->render_view();
+  content::RenderView* render_view = instance->GetRenderView();
   WebKit::WebFrame* frame = render_view->GetWebView()->mainFrame();
   content::Referrer referrer(frame->document().url(),
                              frame->document().referrerPolicy());