Issue 19744004: remove dead defines from skia.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19744004: remove dead defines from skia.gyp (Closed)

Created:
7 years, 5 months ago by reed1

Modified:
6 years, 11 months ago

Reviewers:
bungeman-skia, djsollen

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

remove dead defines from skia.gyp BUG=

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	skia/skia.gyp	View		3 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

Note that this will need to be rebaselined now that everything has changed with r213080.

7 years, 5 months ago (2013-07-24 15:21:16 UTC) #2

bungeman-skia

reed started trying to remove these, and then djsollen's change made this CL obsolete (but ...

7 years, 3 months ago (2013-09-19 14:13:24 UTC) #3

bungeman-skia

6 years, 11 months ago (2014-01-23 18:34:06 UTC) #5

On 2014/01/23 16:51:35, djsollen wrote:
> Is this CL valid anymore? should it be closed?

These were in skia/skia.gyp, were moved to skia/skia_library.gyp, and looks like
all the defines removed here were removed with chromium r224707 (see
https://codereview.chromium.org/24146010 ). So these changes have now gone in.

Expand Messages | Collapse Messages