Web Animations: Add CSSAnimatableValueFactory API (partial implementation)

Source/core/css/resolver/CSSAnimatableValueFactory.cpp

+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "core/css/resolver/CSSAnimatableValueFactory.h"
+
+#include "CSSValueKeywords.h"
+#include "core/animation/AnimatableNumber.h"
+#include "core/animation/AnimatableUnknown.h"
+#include "core/rendering/style/RenderStyle.h"
+
+
+namespace WebCore {
+
+// FIXME: Handle remaining animatable properties:

[dstockwell, 2013/07/30 03:35:04]

Where does this list come from? It should be at least everything in
CSSPropertyAnimation

[alancutter (OOO until 2018), 2013/07/30 08:31:02]

Updated list using CSSPropertyAnimation.

+// CSSPropertyBackgroundColor
+// CSSPropertyBackgroundPosition
+// CSSPropertyBorderBottomColor
+// CSSPropertyBorderBottomWidth
+// CSSPropertyBorderLeftColor
+// CSSPropertyBorderLeftWidth
+// CSSPropertyBorderRightColor
+// CSSPropertyBorderRightWidth
+// CSSPropertyBorderSpacing
+// CSSPropertyBorderTopColor
+// CSSPropertyBorderTopWidth
+// CSSPropertyBottom
+// CSSPropertyClip
+// CSSPropertyColor
+// CSSPropertyFontSize
+// CSSPropertyFontWeight
+// CSSPropertyLetterSpacing
+// CSSPropertyLineHeight
+// CSSPropertyOpacity
+// CSSPropertyOutlineColor
+// CSSPropertyOutlineOffset
+// CSSPropertyOutlineWidth
+// CSSPropertyTextIndent
+// CSSPropertyTextShadow
+// CSSPropertyVerticalAlign
+// CSSPropertyVisibility
+// CSSPropertyWebkitTransform
+// CSSPropertyWordSpacing
+// CSSPropertyZIndex
+
+PassRefPtr<AnimatableValue> CSSAnimatableValueFactory::createFromCSSValue(CSSValue* value, CSSPropertyID property)
+{
+    switch (property) {
+    case CSSPropertyBottom:
+    case CSSPropertyHeight:
+    case CSSPropertyLeft:
+    case CSSPropertyMarginBottom:
+    case CSSPropertyMarginLeft:
+    case CSSPropertyMarginRight:
+    case CSSPropertyMarginTop:
+    case CSSPropertyMaxHeight:
+    case CSSPropertyMaxWidth:
+    case CSSPropertyMinHeight:
+    case CSSPropertyMinWidth:
+    case CSSPropertyPaddingBottom:
+    case CSSPropertyPaddingLeft:
+    case CSSPropertyPaddingRight:
+    case CSSPropertyPaddingTop:
+    case CSSPropertyRight:
+    case CSSPropertyTop:
+    case CSSPropertyWebkitPerspectiveOriginX:
+    case CSSPropertyWebkitPerspectiveOriginY:
+    case CSSPropertyWebkitTransformOriginX:
+    case CSSPropertyWebkitTransformOriginY:
+    case CSSPropertyWidth:
+        if (AnimatableNumber::canCreateFrom(value))

[dstockwell, 2013/07/30 03:35:04]

otherwise, shouldn't we create an AnimatableUnknown?

[alancutter (OOO until 2018), 2013/07/30 08:31:02]

Function removed from patch.

+            return AnimatableNumber::create(value);
+    default:
+        return AnimatableUnknown::create(value);
+    }
+    ASSERT_NOT_REACHED();
+    return 0;
+}
+
+// FIXME: Generate this function.
+PassRefPtr<AnimatableValue> CSSAnimatableValueFactory::createFromRenderStyle(RenderStyle* style, CSSPropertyID property)
+{
+    switch (property) {
+    case CSSPropertyBottom:
+        return createFromLength(style->bottom(), style);
+    case CSSPropertyHeight:
+        return createFromLength(style->height(), style);
+    case CSSPropertyLeft:
+        return createFromLength(style->left(), style);
+    case CSSPropertyMarginBottom:
+        return createFromLength(style->marginBottom(), style);
+    case CSSPropertyMarginLeft:
+        return createFromLength(style->marginLeft(), style);
+    case CSSPropertyMarginRight:
+        return createFromLength(style->marginRight(), style);
+    case CSSPropertyMarginTop:
+        return createFromLength(style->marginTop(), style);
+    case CSSPropertyMaxHeight:
+        return createFromLength(style->maxHeight(), style);
+    case CSSPropertyMaxWidth:
+        return createFromLength(style->maxWidth(), style);
+    case CSSPropertyMinHeight:
+        return createFromLength(style->minHeight(), style);
+    case CSSPropertyMinWidth:
+        return createFromLength(style->minWidth(), style);
+    case CSSPropertyPaddingBottom:
+        return createFromLength(style->paddingBottom(), style);
+    case CSSPropertyPaddingLeft:
+        return createFromLength(style->paddingLeft(), style);
+    case CSSPropertyPaddingRight:
+        return createFromLength(style->paddingRight(), style);
+    case CSSPropertyPaddingTop:
+        return createFromLength(style->paddingTop(), style);
+    case CSSPropertyRight:
+        return createFromLength(style->right(), style);
+    case CSSPropertyTop:
+        return createFromLength(style->top(), style);
+    case CSSPropertyWebkitPerspectiveOriginX:
+        return createFromLength(style->perspectiveOriginX(), style);
+    case CSSPropertyWebkitPerspectiveOriginY:
+        return createFromLength(style->perspectiveOriginY(), style);
+    case CSSPropertyWebkitTransformOriginX:
+        return createFromLength(style->transformOriginX(), style);
+    case CSSPropertyWebkitTransformOriginY:
+        return createFromLength(style->transformOriginY(), style);
+    case CSSPropertyWidth:
+        return createFromLength(style->width(), style);
+    default:
+        ASSERT_WITH_MESSAGE(false, "Unable to create property CSS value from render style, not yet implemented!");
+        return 0;
+    }
+    ASSERT_NOT_REACHED();

[dstockwell, 2013/07/30 03:35:04]

doesn't default: with return mean this can't ever be reached?

[alancutter (OOO until 2018), 2013/07/30 08:31:02]

Done.

+    return 0;
+}
+
+PassRefPtr<AnimatableValue> CSSAnimatableValueFactory::createFromLength(const Length& length, RenderStyle* style)
+{
+    switch (length.type()) {
+    case Relative:
+        return AnimatableNumber::create(length.value(), AnimatableNumber::UnitTypeNumber);
+    case Fixed:
+        return AnimatableNumber::create(adjustFloatForAbsoluteZoom(length.value(), style), AnimatableNumber::UnitTypeLength);
+    case Percent:
+        return AnimatableNumber::create(length.value(), AnimatableNumber::UnitTypePercentage);
+    case ViewportPercentageWidth:
+        return AnimatableNumber::create(length.value(), AnimatableNumber::UnitTypeViewportWidth);
+    case ViewportPercentageHeight:
+        return AnimatableNumber::create(length.value(), AnimatableNumber::UnitTypeViewportHeight);
+    case ViewportPercentageMin:
+        return AnimatableNumber::create(length.value(), AnimatableNumber::UnitTypeViewportMin);
+    case ViewportPercentageMax:
+        return AnimatableNumber::create(length.value(), AnimatableNumber::UnitTypeViewportMax);
+    case Calculated:
+        // FIXME: Convert platform calcs to CSS calcs.
+        ASSERT_WITH_MESSAGE(false, "Unable to convert platform CalculationValue to AnimatableValue, not yet implemented!");

[dstockwell, 2013/07/30 03:35:04]

I was surprised that we didn't already have this problem. How hard is it for
AnimatableNumber to store the platform calc, and perform this conversion in
toCSSValue?

[alancutter (OOO until 2018), 2013/07/30 08:31:02]

It's not particularly difficult though I would prefer to keep it as a separate
patch.

+        return 0;
+    case Auto:
+    case Intrinsic:
+    case MinIntrinsic:
+    case MinContent:
+    case MaxContent:
+    case FillAvailable:
+    case FitContent:
+        return AnimatableUnknown::create(CSSPrimitiveValue::create(length));
+    case Undefined:
+        return AnimatableUnknown::create(CSSPrimitiveValue::create(CSSValueNone));
+    case ExtendToZoom: // Does not apply to elements.
+        ASSERT_NOT_REACHED();
+        return 0;
+    }
+    ASSERT_NOT_REACHED();
+    return 0;
+}
+
+} // namespace WebCore