Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: net/quic/congestion_control/cubic_bytes_test.cc

Issue 1974333004: Remove CubicTest::CwndIncreaseStatsDuringConvexRegion because it expects and asserts nothing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@121604756
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/congestion_control/cubic_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/congestion_control/cubic_bytes_test.cc
diff --git a/net/quic/congestion_control/cubic_bytes_test.cc b/net/quic/congestion_control/cubic_bytes_test.cc
index 1d4b94ec50023905c4493bb27f2ebf84dc58de52..02504b3f98e3b7a85ed9d6a16a528ceca94a2a0d 100644
--- a/net/quic/congestion_control/cubic_bytes_test.cc
+++ b/net/quic/congestion_control/cubic_bytes_test.cc
@@ -5,7 +5,6 @@
#include "net/quic/congestion_control/cubic_bytes.h"
#include "base/logging.h"
-#include "net/quic/quic_connection_stats.h"
#include "net/quic/test_tools/mock_clock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -75,41 +74,6 @@ TEST_F(CubicBytesTest, AboveOrigin) {
EXPECT_EQ(expected_cwnd, current_cwnd / kDefaultTCPMSS);
}
-TEST_F(CubicBytesTest, CwndIncreaseStatsDuringConvexRegion) {
- const QuicTime::Delta rtt_min = hundred_ms_;
- QuicByteCount current_cwnd = 10 * kDefaultTCPMSS;
- QuicByteCount expected_cwnd = current_cwnd + kDefaultTCPMSS;
- // Initialize controller state.
- clock_.AdvanceTime(one_ms_);
- expected_cwnd =
- cubic_.CongestionWindowAfterAck(kDefaultTCPMSS, current_cwnd, rtt_min);
- current_cwnd = expected_cwnd;
- // Testing Reno mode increase.
- for (int i = 0; i < 48; ++i) {
- for (QuicPacketCount n = 1;
- n < current_cwnd / kDefaultTCPMSS / kNConnectionAlpha; ++n) {
- // Call once per ACK, causing cwnd growth in Reno mode.
- cubic_.CongestionWindowAfterAck(kDefaultTCPMSS, current_cwnd, rtt_min);
- }
- // Advance current time so that cwnd update is allowed to happen by Cubic.
- clock_.AdvanceTime(hundred_ms_);
- current_cwnd =
- cubic_.CongestionWindowAfterAck(kDefaultTCPMSS, current_cwnd, rtt_min);
- expected_cwnd += kDefaultTCPMSS;
- }
-
- // Testing Cubic mode increase.
- for (int i = 0; i < 52; ++i) {
- for (QuicPacketCount n = 1; n < current_cwnd / kDefaultTCPMSS; ++n) {
- // Call once per ACK.
- cubic_.CongestionWindowAfterAck(kDefaultTCPMSS, current_cwnd, rtt_min);
- }
- clock_.AdvanceTime(hundred_ms_);
- current_cwnd =
- cubic_.CongestionWindowAfterAck(kDefaultTCPMSS, current_cwnd, rtt_min);
- }
-}
-
TEST_F(CubicBytesTest, LossEvents) {
const QuicTime::Delta rtt_min = hundred_ms_;
QuicByteCount current_cwnd = 422 * kDefaultTCPMSS;
« no previous file with comments | « no previous file | net/quic/congestion_control/cubic_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698