Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1974323003: Add '--dart-sdk-summary' option to analyzer-cli and use SummaryBasedDartSdk. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add '--dart-sdk-summary' option to analyzer-cli and use SummaryBasedDartSdk. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a4862dd22a4d885602cd1aecfb56b576ce87e55f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -19 lines) Patch
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 4 chunks +9 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 2 chunks +75 lines, -1 line 1 comment Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 3 chunks +20 lines, -7 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 3 chunks +18 lines, -9 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 7 months ago (2016-05-13 17:49:16 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/1974323003/diff/1/pkg/analyzer/lib/src/summary/summary_sdk.dart File pkg/analyzer/lib/src/summary/summary_sdk.dart (right): https://codereview.chromium.org/1974323003/diff/1/pkg/analyzer/lib/src/summary/summary_sdk.dart#newcode197 pkg/analyzer/lib/src/summary/summary_sdk.dart:197: * suitable only for command-line tools, but not ...
4 years, 7 months ago (2016-05-13 18:07:59 UTC) #2
Paul Berry
lgtm
4 years, 7 months ago (2016-05-13 19:54:24 UTC) #3
scheglov
4 years, 7 months ago (2016-05-13 19:56:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a4862dd22a4d885602cd1aecfb56b576ce87e55f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698