Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 1974323002: Move inlineElementContinuation() to LayoutBlockFlow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup. Don't introduce unnecessary type checks. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
index 93006b57f0f2b93a98b286d2d2687c01b6b2991f..c17f2e9a5da87e80e2858658fe89c8f08816abda 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
@@ -534,10 +534,10 @@ void LayoutBoxModelObject::updateFromStyle()
static LayoutSize accumulateInFlowPositionOffsets(const LayoutObject* child)
szager1 2016/05/13 22:08:48 Is there any reason why this shouldn't be a virtua
mstensho (USE GERRIT) 2016/05/15 18:48:37 Done.
{
- if (!child->isAnonymousBlock() || !child->isInFlowPositioned())
+ if (!child->isAnonymousBlock() || !child->isInFlowPositioned() || !child->isLayoutBlockFlow())
return LayoutSize();
LayoutSize offset;
- LayoutObject* p = toLayoutBlock(child)->inlineElementContinuation();
+ LayoutObject* p = toLayoutBlockFlow(child)->inlineElementContinuation();
while (p && p->isLayoutInline()) {
if (p->isInFlowPositioned()) {
LayoutInline* layoutInline = toLayoutInline(p);

Powered by Google App Engine
This is Rietveld 408576698