Move inlineElementContinuation() to LayoutBlockFlow.

Move inlineElementContinuation() to LayoutBlockFlow.

BUG=302024
Committed: https://crrev.com/848380b5778f0eceef3ab429f6679b08089c79b6
Cr-Commit-Position: refs/heads/master@{#394167}

[mstensho (USE GERRIT), 2016-05-13 19:44:30]

mstensho@opera.com changed reviewers:
+ dmazzoni@chromium.org, eae@chromium.org, szager@chromium.org,
wkorman@chromium.org

[mstensho (USE GERRIT), 2016-05-13 19:44:30]

dmazzoni for modules/accessibility/ - the rest of the gang for the rest of the
stuff. :)

[szager1, 2016-05-13 22:08:48]

https://codereview.chromium.org/1974323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right):

https://codereview.chromium.org/1974323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:535: static
LayoutSize accumulateInFlowPositionOffsets(const LayoutObject* child)
Is there any reason why this shouldn't be a virtual method on
LayoutBoxModelObject with an override for LayoutBlockFlow?

(If the answer is "no", then I think this would be a good opportunity to change
it, but it's not essential).

https://codereview.chromium.org/1974323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutInline.cpp (right):

https://codereview.chromium.org/1974323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutInline.cpp:141: static void
updateInFlowPositionOfAnonymousBlockContinuations(LayoutObject* block, const
ComputedStyle& newStyle, const ComputedStyle& oldStyle, LayoutObject*
containingBlockOfEndOfContinuation)
Similarly, this seems like it could be refactored into a method on
LayoutBlockFlow.  Not a big deal, but food for thought.

[mstensho (USE GERRIT), 2016-05-15 18:48:37]

https://codereview.chromium.org/1974323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right):

https://codereview.chromium.org/1974323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:535: static
LayoutSize accumulateInFlowPositionOffsets(const LayoutObject* child)
On 2016/05/13 22:08:48, szager1 wrote:
> Is there any reason why this shouldn't be a virtual method on
> LayoutBoxModelObject with an override for LayoutBlockFlow?
> 
> (If the answer is "no", then I think this would be a good opportunity to
change
> it, but it's not essential).

Done.

https://codereview.chromium.org/1974323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutInline.cpp (right):

https://codereview.chromium.org/1974323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutInline.cpp:141: static void
updateInFlowPositionOfAnonymousBlockContinuations(LayoutObject* block, const
ComputedStyle& newStyle, const ComputedStyle& oldStyle, LayoutObject*
containingBlockOfEndOfContinuation)
On 2016/05/13 22:08:48, szager1 wrote:
> Similarly, this seems like it could be refactored into a method on
> LayoutBlockFlow.  Not a big deal, but food for thought.

Definitely food for thought, but maybe we can deal with it in a later CL, if we
think it's a good idea?

In a way, this is continuation weirdness that probably doesn't have a better
home than LayoutInline, but it sure operates on LayoutBlockFlow objects, on the
other hand. :) No strong opinions, really.

[szager1, 2016-05-15 19:43:04]

lgtm

[mstensho (USE GERRIT), 2016-05-15 21:09:33]

Thanks. Still need dmazzoni for modules/accessibility/

[eae, 2016-05-16 16:31:56]

LGTM

[dmazzoni, 2016-05-17 16:23:15]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-05-17 16:23:16]

lgtm

[commit-bot: I haz the power, 2016-05-17 16:23:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974323002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974323002/60001

[commit-bot: I haz the power, 2016-05-17 18:07:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-17 18:11:55]

Description was changed from

==========
Move inlineElementContinuation() to LayoutBlockFlow.

BUG=302024
==========

to

==========
Move inlineElementContinuation() to LayoutBlockFlow.

BUG=302024

Committed: https://crrev.com/848380b5778f0eceef3ab429f6679b08089c79b6
Cr-Commit-Position: refs/heads/master@{#394167}
==========

[commit-bot: I haz the power, 2016-05-17 18:11:57]

Patchset 4 (id:??) landed as
https://crrev.com/848380b5778f0eceef3ab429f6679b08089c79b6
Cr-Commit-Position: refs/heads/master@{#394167}