Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1974293002: [ignition] Inline the binary op TurboFan code stubs in the bytecode handlers. (Closed)

Created:
4 years, 7 months ago by epertoso
Modified:
4 years, 7 months ago
CC:
oth, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers. Trying to reland http://crrev.com/1902823002. This time some blocks have been shuffled around in the AddStub so that the frame still doesn't get built for the fast path. Committed: https://crrev.com/567160122de0bdb78aea79a9faa0dc15a564484c Cr-Commit-Position: refs/heads/master@{#36251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -137 lines) Patch
M src/code-stubs.h View 12 chunks +23 lines, -11 lines 0 comments Download
M src/code-stubs.cc View 27 chunks +169 lines, -115 lines 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 11 chunks +21 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974293002/1
4 years, 7 months ago (2016-05-13 13:24:50 UTC) #4
epertoso
4 years, 7 months ago (2016-05-13 13:28:40 UTC) #5
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-13 13:29:21 UTC) #6
rmcilroy
LGTM, thanks.
4 years, 7 months ago (2016-05-13 13:32:57 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 13:54:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974293002/1
4 years, 7 months ago (2016-05-13 16:49:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 16:51:42 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/567160122de0bdb78aea79a9faa0dc15a564484c Cr-Commit-Position: refs/heads/master@{#36251}
4 years, 7 months ago (2016-05-13 16:52:22 UTC) #14
adamk
4 years, 7 months ago (2016-05-13 23:48:03 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1978993003/ by adamk@chromium.org.

The reason for reverting is: Causes
cctest/test-serialize/SnapshotDataBlobWithWarmup failure on arm64:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%....

Powered by Google App Engine
This is Rietveld 408576698