Drop libjingle/source/talk directory from DEPS.

Drop libjingle/source/talk directory from DEPS.

Also delete all references to libjingle from the roll_webrtc.py and checklicenses scripts.

BUG=webrtc:4256, 98310
Committed: https://crrev.com/d0fa3c06d24d1ccf0d4547aed96e605ae6bd0fa0
Cr-Commit-Position: refs/heads/master@{#393819}

[nisse-chromium (ooo August 14), 2016-05-13 09:13:10]

nisse@chromium.org changed reviewers:
+ kjellander@chromium.org

[nisse-chromium (ooo August 14), 2016-05-13 09:13:11]

Seems to work, I tested by running ./tools/roll_webrtc.py --dry-run
--ignore-checks. 

Is there any Chrome bug number this cl ought to refer to?

[kjellander_chromium, 2016-05-13 09:47:17]

Thanks for doing this! Just a few minor comments.

I don't have any Chrome bug, the WebRTC bug is enough IMO.

https://codereview.chromium.org/1974253003/diff/1/tools/roll_webrtc.py
File tools/roll_webrtc.py (left):

https://codereview.chromium.org/1974253003/diff/1/tools/roll_webrtc.py#oldcod...
tools/roll_webrtc.py:165: if webrtc_current.git_commit != webrtc_new.git_commit:
Please remove line 165: it should always be true now (or the CL would be a
no-op, rendering no changes)

It was there since there could be a roll that included Libjingle-only changes,
which should not be possible anymore.

https://codereview.chromium.org/1974253003/diff/1/tools/roll_webrtc.py#oldcod...
tools/roll_webrtc.py:183: if webrtc_str:
You can remove line 183 too after removing the check at line 165.

https://codereview.chromium.org/1974253003/diff/1/tools/roll_webrtc.py#oldcod...
tools/roll_webrtc.py:184: description.extend(['-m', webrtc_str])
I suggest dropping adding this to the description. It's already in the title of
the CL so this is just repeating the same thing (see
https://codereview.chromium.org/1920743002/ for an example CL).

[nisse-chromium (ooo August 14), 2016-05-13 10:09:13]

Updated version. Example cl produced by the script:

https://codereview.chromium.org/1980453002/

[kjellander_chromium, 2016-05-13 10:54:13]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2016-05-13 10:54:13]

lgtm

[commit-bot: I haz the power, 2016-05-13 10:54:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974253003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974253003/20001

[commit-bot: I haz the power, 2016-05-13 12:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 12:57:52]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nisse-chromium (ooo August 14), 2016-05-13 13:26:11]

On 2016/05/13 12:57:52, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Failure from 

  webview_licenses (with patch) webview_licenses (with patch) 
  failures:
  third_party/libjingle

I guess this is because the file third_party/libjingle/source/talk/COPYING has
disappeared together with the talk directory. There's a pointer in it in
README.chromium. Should I point that to webrtc's COPYING instead, or update it
in some other way?

Other questions: The overrides directory contains four files (DEPS,
field_trial.cc, init_webrtc.cc, and init_webrtc.h). Should they be deleted too?

tools/checklicenses/checklicenses.py also has a reference to
libjingle/source/talk, and to http://crbug.com/98310.

[kjellander_chromium, 2016-05-13 13:38:04]

On 2016/05/13 13:26:11, nisse-chromium wrote:
> On 2016/05/13 12:57:52, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
> 
> Failure from 
> 
>   webview_licenses (with patch) webview_licenses (with patch) 
>   failures:
>   third_party/libjingle
> 
> I guess this is because the file third_party/libjingle/source/talk/COPYING has
> disappeared together with the talk directory. There's a pointer in it in
> README.chromium. Should I point that to webrtc's COPYING instead, or update it
> in some other way?

I haven't done this, but the error suggests you can "add a 'License File:' line
to README.chromium with the appropriate path.". 
However, there's no COPYING file in Chromium's src/third_party/webrtc since it's
a mirror of our webrtc/ subdir:
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/
So I think it's better you add a LICENSE file in src/third_party/libjingle
instead (as also suggested in the error message).

> Other questions: The overrides directory contains four files (DEPS,
> field_trial.cc, init_webrtc.cc, and init_webrtc.h). Should they be deleted
too?

No, they're needed by WebRTC.

> tools/checklicenses/checklicenses.py also has a reference to
> libjingle/source/talk, and to http://crbug.com/98310.

I guess you can remove that reference since the dir will now be gone. You'll
need additional reviewer for that though (pick phajdan.jr)

[nisse-chromium (ooo August 14), 2016-05-16 07:00:56]

On 2016/05/13 13:38:04, kjellander (chromium) wrote:
> However, there's no COPYING file in Chromium's src/third_party/webrtc since
it's
> a mirror of our webrtc/ subdir:
> https://chromium.googlesource.com/external/webrtc/+/master/webrtc/

Hmm. I have such a file. The toplevel LICENCE file says in my webrtc checkout
only says "Refer to webrtc/LICENSE." 

So letting third_party/libjingle/README/chromium point to ../webrtc/LICENSE
seems to work, at lest when I run webview_licenses locally.

> > Other questions: The overrides directory contains four files (DEPS,
> > field_trial.cc, init_webrtc.cc, and init_webrtc.h). Should they be deleted
> too?
> 
> No, they're needed by WebRTC.

All four of them? I'm leaving them as is, then.

> > tools/checklicenses/checklicenses.py also has a reference to
> > libjingle/source/talk, and to http://crbug.com/98310.
> 
> I guess you can remove that reference since the dir will now be gone. You'll
> need additional reviewer for that though (pick phajdan.jr)

I'll do that (and add a reference to the bug, which is going to be fixed with
this cl).

[nisse-chromium (ooo August 14), 2016-05-16 07:02:54]

Description was changed from

==========
Drop libjingle/source/talk directory from DEPS.

Also delete all references to libjingle from the roll_webrtc.py script.

BUG=webrtc:4256
==========

to

==========
Drop libjingle/source/talk directory from DEPS.

Also delete all references to libjingle from the roll_webrtc.py and
checklicenses scripts.

BUG=webrtc:4256,98310
==========

[nisse-chromium (ooo August 14), 2016-05-16 07:02:54]

nisse@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[nisse-chromium (ooo August 14), 2016-05-16 07:04:21]

The CQ bit was checked by nisse@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-16 07:04:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974253003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974253003/40001

[commit-bot: I haz the power, 2016-05-16 07:06:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 07:06:11]

Dry run: Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[kjellander_chromium, 2016-05-16 07:18:27]

lgtm assuming a rebased patch set passes the trybots.

[nisse-chromium (ooo August 14), 2016-05-16 08:59:49]

The CQ bit was checked by nisse@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-16 08:59:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974253003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974253003/60001

[Paweł Hajdan Jr., 2016-05-16 09:55:31]

LGTM

[commit-bot: I haz the power, 2016-05-16 10:13:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 10:13:11]

Dry run: This issue passed the CQ dry run.

[nisse-chromium (ooo August 14), 2016-05-16 11:34:40]

The CQ bit was checked by nisse@chromium.org

[nisse-chromium (ooo August 14), 2016-05-16 11:34:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@chromium.org
Link to the patchset: https://codereview.chromium.org/1974253003/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-05-16 11:34:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974253003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974253003/60001

[commit-bot: I haz the power, 2016-05-16 11:38:28]

Description was changed from

==========
Drop libjingle/source/talk directory from DEPS.

Also delete all references to libjingle from the roll_webrtc.py and
checklicenses scripts.

BUG=webrtc:4256,98310
==========

to

==========
Drop libjingle/source/talk directory from DEPS.

Also delete all references to libjingle from the roll_webrtc.py and
checklicenses scripts.

BUG=webrtc:4256,98310
==========

[commit-bot: I haz the power, 2016-05-16 11:38:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-16 11:39:58]

Description was changed from

==========
Drop libjingle/source/talk directory from DEPS.

Also delete all references to libjingle from the roll_webrtc.py and
checklicenses scripts.

BUG=webrtc:4256,98310
==========

to

==========
Drop libjingle/source/talk directory from DEPS.

Also delete all references to libjingle from the roll_webrtc.py and
checklicenses scripts.

BUG=webrtc:4256,98310

Committed: https://crrev.com/d0fa3c06d24d1ccf0d4547aed96e605ae6bd0fa0
Cr-Commit-Position: refs/heads/master@{#393819}
==========

[commit-bot: I haz the power, 2016-05-16 11:39:59]

Patchset 4 (id:??) landed as
https://crrev.com/d0fa3c06d24d1ccf0d4547aed96e605ae6bd0fa0
Cr-Commit-Position: refs/heads/master@{#393819}