Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1974233002: Avoid race on uninitializing CrossThreadPersistent nodes. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid race on uninitializing CrossThreadPersistent nodes. R= BUG=611593, 611594 Committed: https://crrev.com/599c0724311759cb37ed1be9971fa694eee766ca Cr-Commit-Position: refs/heads/master@{#393488}

Patch Set 1 #

Patch Set 2 : symmetric acquire/release #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M third_party/WebKit/Source/platform/heap/Handle.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentNode.h View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-13 06:47:23 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-13 06:55:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974233002/20001
4 years, 7 months ago (2016-05-13 08:36:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 09:19:48 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 09:21:18 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/599c0724311759cb37ed1be9971fa694eee766ca
Cr-Commit-Position: refs/heads/master@{#393488}

Powered by Google App Engine
This is Rietveld 408576698