Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1974203002: Disabling skip_gpu_process test. (Closed)

Created:
4 years, 7 months ago by cblume
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling skip_gpu_process test. There was no good way to skip this test on Android (where it is failing) so we decided to simply disable the test. It provides little value and is keeping the Android bots from being green on the Chromium recipe. We should come back and provide a way to only skip this on Android (so we can run the test again). BUG=490984, 611629 R=kbr@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/4e00ce63d29e2197bcd35b5419add1a7a06f0eda Cr-Commit-Position: refs/heads/master@{#393429}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding TODO comment to explain why it is skipped. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/test/gpu/page_sets/gpu_process_tests.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Ken Russell (switch to Gerrit)
lgtm with comment https://codereview.chromium.org/1974203002/diff/1/content/test/gpu/page_sets/gpu_process_tests.py File content/test/gpu/page_sets/gpu_process_tests.py (right): https://codereview.chromium.org/1974203002/diff/1/content/test/gpu/page_sets/gpu_process_tests.py#newcode525 content/test/gpu/page_sets/gpu_process_tests.py:525: #self.AddStory(SkipGpuProcessPage(self, expectations)) Please add: TODO(cblume): no ...
4 years, 7 months ago (2016-05-13 01:50:24 UTC) #2
cblume
https://codereview.chromium.org/1974203002/diff/1/content/test/gpu/page_sets/gpu_process_tests.py File content/test/gpu/page_sets/gpu_process_tests.py (right): https://codereview.chromium.org/1974203002/diff/1/content/test/gpu/page_sets/gpu_process_tests.py#newcode525 content/test/gpu/page_sets/gpu_process_tests.py:525: #self.AddStory(SkipGpuProcessPage(self, expectations)) On 2016/05/13 01:50:24, Ken Russell wrote: > ...
4 years, 7 months ago (2016-05-13 01:54:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974203002/20001
4 years, 7 months ago (2016-05-13 01:55:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 01:58:50 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 02:00:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e00ce63d29e2197bcd35b5419add1a7a06f0eda
Cr-Commit-Position: refs/heads/master@{#393429}

Powered by Google App Engine
This is Rietveld 408576698