Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7591)

Unified Diff: chrome/browser/resources/settings/settings_dialog.js

Issue 1974193002: MD Settings: fix overflow scrolling for <settings-dialog> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-polish3
Patch Set: fix border Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_dialog.js
diff --git a/chrome/browser/resources/settings/settings_dialog.js b/chrome/browser/resources/settings/settings_dialog.js
index 888ae0d4c5cc5df61b9a4919539ac91877657e0f..ae083ba84fcc865cd9f511736dbfc35b7fb8da50 100644
--- a/chrome/browser/resources/settings/settings_dialog.js
+++ b/chrome/browser/resources/settings/settings_dialog.js
@@ -21,6 +21,13 @@ Polymer({
value: false,
},
+ sizingTarget: {
+ type: Element,
+ value: function() {
+ return this.$$('.body-container');
+ },
+ },
+
/** @override */
withBackdrop: {
type: Boolean,
@@ -34,4 +41,15 @@ Polymer({
getCloseButton: function() {
return this.$.close;
},
+
+ /** @override */
+ _renderOpened: function() {
dpapad 2016/05/25 01:32:28 Ah, not a huge fun of this, but I understand. Cou
Dan Beam 2016/05/25 02:07:49 added more context
+ // Stay hidden until fully rendered because Iron{Fit,Overlay}Behavior don't
+ // deal well with light DOM changing while showing.
+ this.debounce('_renderOpened', function() {
+ this.refit();
+ Polymer.IronOverlayBehaviorImpl._renderOpened.call(this);
+ this.classList.add('fully-rendered');
+ }, 1);
+ },
});

Powered by Google App Engine
This is Rietveld 408576698