chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html - Issue 1974193002: MD Settings: fix overflow scrolling for <settings-dialog>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html

Issue 1974193002: MD Settings: fix overflow scrolling for <settings-dialog> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-polish3

Patch Set: nit Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/reset_page/reset_profile_dialog.html ('k') | chrome/browser/resources/settings/settings_dialog.html » ('j') | chrome/browser/resources/settings/settings_dialog.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">

4 <link rel="import" href="chrome://md-settings/i18n_setup.html">	4 <link rel="import" href="chrome://md-settings/i18n_setup.html">

5 <link rel="import" href="chrome://md-settings/search_engines_page/search_engines _browser_proxy.html">	5 <link rel="import" href="chrome://md-settings/search_engines_page/search_engines _browser_proxy.html">

6 <link rel="import" href="chrome://md-settings/settings_dialog.html">	6 <link rel="import" href="chrome://md-settings/settings_dialog.html">

7	7

8 <dom-module id="settings-search-engine-dialog">	8 <dom-module id="settings-search-engine-dialog">

9 <template>	9 <template>

10 <style include="settings-shared"></style>	10 <style include="settings-shared"></style>

(...skipping 11 matching lines...) Expand all Loading...
22 error-message="$i18n{searchEnginesNotValid}"	22 error-message="$i18n{searchEnginesNotValid}"

23 value="{{keyword_}}" on-focus="validate_" on-input="validate_">	23 value="{{keyword_}}" on-focus="validate_" on-input="validate_">

24 </paper-input>	24 </paper-input>

25 <paper-input always-float-label id="queryUrl"	25 <paper-input always-float-label id="queryUrl"

26 label="$i18n{searchEnginesQueryURLExplanation}"	26 label="$i18n{searchEnginesQueryURLExplanation}"

27 error-message="$i18n{searchEnginesNotValid}"	27 error-message="$i18n{searchEnginesNotValid}"

28 value="{{queryUrl_}}" on-focus="validate_" on-input="validate_"	28 value="{{queryUrl_}}" on-focus="validate_" on-input="validate_"

29 disabled$="[[model.urlLocked]]">	29 disabled$="[[model.urlLocked]]">

30 </paper-input>	30 </paper-input>

31 </div>	31 </div>

32 <div class="button-container">	32 <div class="buttons">

33 <paper-button class="cancel-button" on-tap="cancel_" id="cancel">	33 <paper-button class="cancel-button" on-tap="cancel_" id="cancel">

34 $i18n{cancel}</paper-button>	34 $i18n{cancel}</paper-button>

35 <paper-button id="actionButton" class="action-button"	35 <paper-button id="actionButton" class="action-button"

36 on-tap="onActionButtonTap_">	36 on-tap="onActionButtonTap_">

37 [[actionButtonText_]]	37 [[actionButtonText_]]

38 </paper-button>	38 </paper-button>

39 </div>	39 </div>

40 </settings-dialog>	40 </settings-dialog>

41 </template>	41 </template>

42 <script src="search_engine_dialog.js"></script>	42 <script src="search_engine_dialog.js"></script>

43 </dom-module>	43 </dom-module>

OLD	NEW