Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp

Issue 1974163003: Expose GpuMemoryBufferId through glGetImageivCHROMIUM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp b/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
index 30d56946d68c3acfff79a7d54ab776f3f432700d..9cdf2c773cc4840caaa53769858e4b9e4142d745 100644
--- a/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
+++ b/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
@@ -217,6 +217,7 @@ bool Canvas2DLayerBridge::prepareIOSurfaceMailboxFromImage(SkImage* image, WebEx
gl->Flush();
gl->GenSyncTokenCHROMIUM(fenceSync, info.m_mailbox.syncToken);
info.m_mailbox.validSyncToken = true;
+ info.m_mailbox.gpuMemoryBufferId = imageInfo.m_gpuMemoryBufferId;
info.m_imageInfo = imageInfo;
*outMailbox = info.m_mailbox;
@@ -256,7 +257,11 @@ Canvas2DLayerBridge::ImageInfo Canvas2DLayerBridge::createIOSurfaceBackedTexture
gl->TexParameteri(target, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
gl->BindTexImage2DCHROMIUM(target, imageId);
- return Canvas2DLayerBridge::ImageInfo(imageId, textureId);
+ GLint gpuMemoryBufferId = -1;
+ gl->GetImageivCHROMIUM(imageId, GC3D_GPU_MEMORY_BUFFER_ID, &gpuMemoryBufferId);
+ DCHECK_NE(-1, gpuMemoryBufferId);
+
+ return Canvas2DLayerBridge::ImageInfo(imageId, textureId, gpuMemoryBufferId);
}
void Canvas2DLayerBridge::deleteCHROMIUMImage(ImageInfo info)
@@ -961,10 +966,14 @@ void Canvas2DLayerBridge::willOverwriteCanvas()
}
#if USE_IOSURFACE_FOR_2D_CANVAS
-Canvas2DLayerBridge::ImageInfo::ImageInfo(GLuint imageId, GLuint textureId) : m_imageId(imageId), m_textureId(textureId)
+Canvas2DLayerBridge::ImageInfo::ImageInfo(GLuint imageId, GLuint textureId, GLint gpuMemoryBufferId)
+ : m_imageId(imageId)
+ , m_textureId(textureId)
+ , m_gpuMemoryBufferId(gpuMemoryBufferId)
{
ASSERT(imageId);
ASSERT(textureId);
+ DCHECK_NE(-1, gpuMemoryBufferId);
}
bool Canvas2DLayerBridge::ImageInfo::empty()

Powered by Google App Engine
This is Rietveld 408576698