Add an experiment for the default browser infobar on Windows 10

chrome/browser/ui/startup/default_browser_prompt.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/default_browser_prompt.h"
 
+#include <limits>

[Patrick Monette, 2016/05/12 23:43:25]

This fixes a lint error.

 #include <string>
 
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/user_metrics_action.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
@@ skipping 15 matching lines @@
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service.h"
 #include "components/variations/variations_associated_data.h"
 #include "components/version_info/version_info.h"
 #include "content/public/browser/user_metrics.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/vector_icons_public.h"
 
 #if defined(OS_WIN)
+#include "base/feature_list.h"
 #include "base/win/windows_version.h"
 #endif
 
 namespace {
 
+bool IsStickyDefaultBrowserInfobarEnabled() {
+#if defined(OS_WIN)
+  static const base::Feature kStickyDefaultBrowserInfobar{

[Peter Kasting, 2016/05/17 03:07:37]

Nit: Can be constexpr

[Patrick Monette, 2016/05/31 15:19:41]

I can't manage to make it constexpr now that I'm declaring it in the header
file.

+      "StickyDefaultBrowserInfobar", base::FEATURE_DISABLED_BY_DEFAULT};
+
+  // The flow to set the default browser is only asynchronous on Windows 10+.
+  return base::win::GetVersion() >= base::win::VERSION_WIN10 &&
+         base::FeatureList::IsEnabled(kStickyDefaultBrowserInfobar);
+#else
+  return false;
+#endif
+}
+
 // The delegate for the infobar shown when Chrome is not the default browser.
 // Ownership of the delegate is given to the infobar itself, the lifetime of
 // which is bound to the containing WebContents.
 class DefaultBrowserInfoBarDelegate : public ConfirmInfoBarDelegate {
  public:
   // Creates a default browser infobar and delegate and adds the infobar to
   // |infobar_service|.
   static void Create(InfoBarService* infobar_service, Profile* profile);
 
  private:
@@ skipping 22 matching lines @@
   bool ShouldExpire(const NavigationDetails& details) const override;
   void InfoBarDismissed() override;
 
   // ConfirmInfoBarDelegate:
   base::string16 GetMessageText() const override;
   base::string16 GetButtonLabel(InfoBarButton button) const override;
   bool OKButtonTriggersUACPrompt() const override;
   bool Accept() override;
   bool Cancel() override;
 
+  // Removes the infobar when the worker is finished setting the default
+  // browser. Only used if the StickyDefaultBrowserInfobar experiment is
+  // enabled.
+  void OnSetAsDefaultFinished(
+      shell_integration::DefaultWebClientState /* state */);

[Peter Kasting, 2016/05/17 03:07:37]

Nit: No /* */; put the name uncommented here and below.  (Chromium does not warn
on unused named params.)

[Patrick Monette, 2016/05/31 15:19:41]

Done.

+
   // The WebContents's corresponding profile.
   Profile* profile_;
 
   // Whether the info-bar should be dismissed on the next navigation.
   bool should_expire_ = false;
 
   // Used to delay the expiration of the info-bar.
   base::WeakPtrFactory<DefaultBrowserInfoBarDelegate> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DefaultBrowserInfoBarDelegate);
@@ skipping 86 matching lines @@
 bool DefaultBrowserInfoBarDelegate::OKButtonTriggersUACPrompt() const {
   return shell_integration::IsElevationNeededForSettingDefaultProtocolClient();
 }
 
 bool DefaultBrowserInfoBarDelegate::Accept() {
   content::RecordAction(
       base::UserMetricsAction("DefaultBrowserInfoBar_Accept"));
   UMA_HISTOGRAM_ENUMERATION("DefaultBrowser.InfoBar.UserInteraction",
                             ACCEPT_INFO_BAR,
                             NUM_INFO_BAR_USER_INTERACTION_TYPES);
+
+  bool close_infobar = true;
+  shell_integration::DefaultWebClientWorkerCallback set_as_default_callback;
+
+  if (IsStickyDefaultBrowserInfobarEnabled()) {
+    // When the experiment is enabled, the infobar is only closed when the
+    // DefaultBrowserWorker is finished.
+    set_as_default_callback =
+        base::Bind(&DefaultBrowserInfoBarDelegate::OnSetAsDefaultFinished,
+                   weak_factory_.GetWeakPtr());
+    close_infobar = false;
+  }
+
   // The worker pointer is reference counted. While it is running, the
   // message loops of the FILE and UI thread will hold references to it
   // and it will be automatically freed once all its tasks have finished.
   scoped_refptr<shell_integration::DefaultBrowserWorker>(
-      new shell_integration::DefaultBrowserWorker(
-          shell_integration::DefaultWebClientWorkerCallback()))
+      new shell_integration::DefaultBrowserWorker(set_as_default_callback))
       ->StartSetAsDefault();
-  return true;
+  return close_infobar;
 }
 
 bool DefaultBrowserInfoBarDelegate::Cancel() {
   chrome::DefaultBrowserPromptDeclined(profile_);
   content::RecordAction(
       base::UserMetricsAction("DefaultBrowserInfoBar_Cancel"));
   UMA_HISTOGRAM_ENUMERATION("DefaultBrowser.InfoBar.UserInteraction",
                             CANCEL_INFO_BAR,
                             NUM_INFO_BAR_USER_INTERACTION_TYPES);
   return true;
 }
 
+void DefaultBrowserInfoBarDelegate::OnSetAsDefaultFinished(
+    shell_integration::DefaultWebClientState /* state */) {
+  infobar()->owner()->RemoveInfoBar(infobar());
+}
+
 void ResetCheckDefaultBrowserPref(const base::FilePath& profile_path) {
   Profile* profile =
       g_browser_process->profile_manager()->GetProfileByPath(profile_path);
   if (profile)
     chrome::ResetDefaultBrowserPrompt(profile);
 }
 
 void ShowPrompt() {
   Browser* browser = chrome::FindLastActive();
   if (!browser)
@@ skipping 102 matching lines @@
   profile->GetPrefs()->ClearPref(prefs::kDefaultBrowserLastDeclined);
 }
 
 #if !defined(OS_WIN)
 bool ShowFirstRunDefaultBrowserPrompt(Profile* profile) {
   return false;
 }
 #endif
 
 }  // namespace chrome