Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1974133002: sync compositor: Remove sync input path (Closed)

Created:
4 years, 7 months ago by boliu
Modified:
4 years, 6 months ago
Reviewers:
no sievers, dcheng
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sync compositor: Remove sync input path Remove kSyncInputForSyncCompositor switch and all code behind it. M51 shipped without it and looks fine, so remove all the code. BUG=545628 Committed: https://crrev.com/b2768db29f9135930be0b05d0a817a96337d9afe Cr-Commit-Position: refs/heads/master@{#397841}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -163 lines) Patch
M content/browser/android/synchronous_compositor_host.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M content/browser/android/synchronous_compositor_host.cc View 1 5 chunks +1 line, -30 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/android/sync_compositor_messages.h View 1 2 chunks +0 lines, -10 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/android/synchronous_compositor_filter.h View 1 4 chunks +0 lines, -14 lines 0 comments Download
M content/renderer/android/synchronous_compositor_filter.cc View 1 2 chunks +3 lines, -43 lines 0 comments Download
M content/renderer/android/synchronous_compositor_proxy.h View 1 5 chunks +1 line, -10 lines 0 comments Download
M content/renderer/android/synchronous_compositor_proxy.cc View 1 6 chunks +1 line, -29 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
boliu
ptal
4 years, 6 months ago (2016-06-02 15:30:29 UTC) #2
no sievers
lgtm
4 years, 6 months ago (2016-06-03 20:38:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974133002/20001
4 years, 6 months ago (2016-06-03 20:40:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/194996) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-06-03 20:45:11 UTC) #7
boliu
+dcheng for ipc
4 years, 6 months ago (2016-06-03 20:46:05 UTC) #9
dcheng
Yay! LGTM
4 years, 6 months ago (2016-06-03 20:46:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974133002/20001
4 years, 6 months ago (2016-06-03 20:47:44 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 23:35:27 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 23:37:48 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b2768db29f9135930be0b05d0a817a96337d9afe
Cr-Commit-Position: refs/heads/master@{#397841}

Powered by Google App Engine
This is Rietveld 408576698