Move extensions-related files to using //components/keyed_service.

Move extensions-related files to using //components/keyed_service.

This CL removes the usage of //components/browser_context_keyed_service
from:
- //chrome/browser/extensions
- //extensions

It was constructed using the following:
- move_source_file.py --already_moved
- mffr.py
- git cl format

BUG=351704
TBR=yoz

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256853

[Jói, 2014-03-12 14:11:55]

LGTM

[blundell, 2014-03-12 14:26:57]

TBR yoz for OWNERS

[blundell, 2014-03-12 14:27:19]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-03-12 14:28:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/197413002/1

[tfarina, 2014-03-12 15:59:21]

Colin, is mffr.py a script of yours?

[blundell, 2014-03-12 16:01:11]

On 2014/03/12 15:59:21, tfarina wrote:
> Colin, is mffr.py a script of yours?

Nope! tools/git/mffr.py. Super-handy for large-scale search-and-replace.

[commit-bot: I haz the power, 2014-03-12 16:31:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 16:31:31]

Retried try job too often on win for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[Jói, 2014-03-12 16:35:16]

Nice to see that it's useful - I wrote mffr.py as part of writing
move_source_file.py :)  One componentizer's work paying off for the
next :)

Cheers,
Jói


On Wed, Mar 12, 2014 at 4:01 PM,  <blundell@chromium.org> wrote:
> On 2014/03/12 15:59:21, tfarina wrote:
>>
>> Colin, is mffr.py a script of yours?
>
>
> Nope! tools/git/mffr.py. Super-handy for large-scale search-and-replace.
>
> https://codereview.chromium.org/197413002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Yoyo Zhou, 2014-03-12 18:30:56]

LGTM
Cool, mffr.py looks easier to use than the git grep -l | xargs sed -i that I've
been using.

https://codereview.chromium.org/197413002/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/networking_private/networking_private_service_client.h
(right):

https://codereview.chromium.org/197413002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/networking_private/networking_private_service_client.h:115:
// BrowserContextKeyedServices method override.
KeyedService

https://codereview.chromium.org/197413002/diff/1/extensions/browser/browser_c...
File extensions/browser/browser_context_keyed_api_factory.h (right):

https://codereview.chromium.org/197413002/diff/1/extensions/browser/browser_c...
extensions/browser/browser_context_keyed_api_factory.h:68: // A template for
factories for BrowserContextKeyedServices that manage
Should all these references be to KeyedService now?

[blundell, 2014-03-12 20:12:15]

The CQ bit was checked by blundell@chromium.org

[blundell, 2014-03-12 20:12:49]

https://codereview.chromium.org/197413002/diff/1/extensions/browser/browser_c...
File extensions/browser/browser_context_keyed_api_factory.h (right):

https://codereview.chromium.org/197413002/diff/1/extensions/browser/browser_c...
extensions/browser/browser_context_keyed_api_factory.h:68: // A template for
factories for BrowserContextKeyedServices that manage
Yep, my mffr.py input didn't account for the plural :). Thanks! Done.

On 2014/03/12 18:30:57, Yoyo Zhou wrote:
> Should all these references be to KeyedService now?

[commit-bot: I haz the power, 2014-03-12 20:14:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/197413002/20001

[commit-bot: I haz the power, 2014-03-13 03:29:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 03:29:35]

Retried try job too often on win for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[blundell, 2014-03-13 08:37:08]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-03-13 08:37:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/197413002/20001

[commit-bot: I haz the power, 2014-03-13 08:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 08:38:07]

Failed to apply patch for chrome/browser/DEPS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/DEPS
  Hunk #1 FAILED at 16.
  1 out of 1 hunk FAILED -- saving rejects to file chrome/browser/DEPS.rej

Patch:       chrome/browser/DEPS
Index: chrome/browser/DEPS
diff --git a/chrome/browser/DEPS b/chrome/browser/DEPS
index
b214bfb010f40e0a63910ffdf220e4591f7a69f3..64b2dfb9300a6f86e6d0b0c406466b11a114c66e
100644
--- a/chrome/browser/DEPS
+++ b/chrome/browser/DEPS
@@ -16,6 +16,7 @@ include_rules = [
   "+components/browser_context_keyed_service",
   "+components/dom_distiller",
   "+components/encryptor",
+  "+components/keyed_service",
   "+components/language_usage_metrics",
   "+components/nacl/browser",
   "+components/nacl/common",

[blundell, 2014-03-13 09:39:57]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-03-13 09:40:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/197413002/40001

[commit-bot: I haz the power, 2014-03-13 09:44:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 09:44:16]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[blundell, 2014-03-13 10:42:56]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-03-13 10:43:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/197413002/40001

[commit-bot: I haz the power, 2014-03-13 17:05:39]

Change committed as 256853