Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1974093003: WIP: Boom (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
epertoso, danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

WIP: Boom # # Fatal error in ../src/compiler/code-assembler.cc, line 677 # Check failed: i != variable_merges_.end() && i->second.size() == merge_count_. # This can be "fixed" by moving {var_boom} declaration to the outermost scope and binding it to some value. I'm not sure if it really has to be this way. Another way is to introduce a {return_true_trampoline} block and jump to {return_true} through it (see Patch Set 2). BUG=chromium:615621

Patch Set 1 #

Patch Set 2 : The trampoline block workaround #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
M src/code-stub-assembler.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Igor Sheludko
PTAL
4 years, 7 months ago (2016-05-13 10:58:55 UTC) #2
Igor Sheludko
On 2016/05/13 10:58:55, Igor Sheludko wrote: > PTAL This can be "fixed" by moving {var_boom} ...
4 years, 7 months ago (2016-05-20 09:01:29 UTC) #4
Igor Sheludko
On 2016/05/20 09:01:29, Igor Sheludko wrote: > On 2016/05/13 10:58:55, Igor Sheludko wrote: > > ...
4 years, 6 months ago (2016-05-28 12:53:37 UTC) #7
Igor Sheludko
4 years, 6 months ago (2016-05-30 13:01:04 UTC) #10
I rebased the CL. 
Define ENABLE_TRAMPOLINE_WORKAROUND to 1 to enable the workaround.

Powered by Google App Engine
This is Rietveld 408576698