Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1974073002: [Sync] Reduce SingleClientSessionsSyncTest.CookieJarMismatch test execution time (Closed)

Created:
4 years, 7 months ago by pavely
Modified:
4 years, 7 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Reduce SingleClientSessionsSyncTest.CookieJarMismatch test execution time During its execution this test triggers two commits to SESSIONS which trigger sync cycles with 10 seconds delay each. This brings test execution time beyond 20 seconds. At the same time test_launcher limits test execution time to 30 seconds. Combination of the above causes test to fail intermittently. I'm adding calls to trigger sync cycle immediately. BUG=603794 R=zea@chromium.org Committed: https://crrev.com/09bb83b8d5854cf9961eb4298f737dd0c2f9a979 Cr-Commit-Position: refs/heads/master@{#393321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pavely
4 years, 7 months ago (2016-05-12 18:20:24 UTC) #2
Nicolas Zea
Nice find! LGTM
4 years, 7 months ago (2016-05-12 18:28:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974073002/1
4 years, 7 months ago (2016-05-12 18:36:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 19:05:29 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 19:06:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09bb83b8d5854cf9961eb4298f737dd0c2f9a979
Cr-Commit-Position: refs/heads/master@{#393321}

Powered by Google App Engine
This is Rietveld 408576698