Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1712)

Unified Diff: sdk/lib/io/websocket.dart

Issue 1974043002: Revert "Fix remaining strong-mode warnings and errors in dart:io." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/stdio.dart ('k') | sdk/lib/io/websocket_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/websocket.dart
diff --git a/sdk/lib/io/websocket.dart b/sdk/lib/io/websocket.dart
index df6c8cf523390d47e14b0986b4cd27ff3815a016..183714fedcce843c68425af99c0eb4bda4922254 100644
--- a/sdk/lib/io/websocket.dart
+++ b/sdk/lib/io/websocket.dart
@@ -212,10 +212,9 @@ abstract class WebSocketTransformer
* then the [WebSocket] will be created with the default [CompressionOptions].
*/
factory WebSocketTransformer(
- {/*String|Future<String>*/ protocolSelector(List<String> protocols),
- CompressionOptions compression: CompressionOptions.DEFAULT}) {
- return new _WebSocketTransformerImpl(protocolSelector, compression);
- }
+ {protocolSelector(List<String> protocols),
+ CompressionOptions compression: CompressionOptions.DEFAULT}) =>
+ new _WebSocketTransformerImpl(protocolSelector, compression);
/**
* Upgrades a [HttpRequest] to a [WebSocket] connection. If the
@@ -253,11 +252,9 @@ abstract class WebSocketTransformer
* A two-way HTTP communication object for client or server applications.
*
* The stream exposes the messages received. A text message will be of type
- * `String` and a binary message will be of type `List<int>`.
+ * [:String:] and a binary message will be of type [:List<int>:].
*/
-abstract class WebSocket
- implements Stream<dynamic/*String|List<int>*/>,
- StreamSink<dynamic/*String|List<int>*/> {
+abstract class WebSocket implements Stream, StreamSink {
/**
* Possible states of the connection.
*/
@@ -392,14 +389,14 @@ abstract class WebSocket
/**
* Sends data on the WebSocket connection. The data in [data] must
- * be either a `String`, or a `List<int>` holding bytes.
+ * be either a [:String:], or a [:List<int>:] holding bytes.
*/
- void add(/*String|List<int>*/ data);
+ void add(data);
/**
* Sends data from a stream on WebSocket connection. Each data event from
* [stream] will be send as a single WebSocket frame. The data from [stream]
- * must be either `String`s, or `List<int>`s holding bytes.
+ * must be either [:String:]s, or [:List<int>:]s holding bytes.
*/
Future addStream(Stream stream);
}
« no previous file with comments | « sdk/lib/io/stdio.dart ('k') | sdk/lib/io/websocket_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698