Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: sdk/lib/io/http_parser.dart

Issue 1974043002: Revert "Fix remaining strong-mode warnings and errors in dart:io." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | sdk/lib/io/io_resource_info.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http_parser.dart
diff --git a/sdk/lib/io/http_parser.dart b/sdk/lib/io/http_parser.dart
index c2b08e40895f472ff4be793108628dace19666a3..5eb96ce350bf05f0d93f61857154f223aca33bde 100644
--- a/sdk/lib/io/http_parser.dart
+++ b/sdk/lib/io/http_parser.dart
@@ -183,7 +183,7 @@ class _HttpDetachedStreamSubscription implements StreamSubscription<List<int>> {
class _HttpDetachedIncoming extends Stream<List<int>> {
- final StreamSubscription<List<int>> subscription;
+ final StreamSubscription subscription;
final List<int> bufferedData;
_HttpDetachedIncoming(this.subscription, this.bufferedData);
@@ -205,8 +205,7 @@ class _HttpDetachedIncoming extends Stream<List<int>> {
onData)
..resume();
} else {
- // TODO(26379): add test for this branch.
- return new Stream<List<int>>.fromIterable([bufferedData])
+ return new Stream.fromIterable(bufferedData)
.listen(onData,
onError: onError,
onDone: onDone,
@@ -268,7 +267,7 @@ class _HttpParser extends Stream<_HttpIncoming> {
// The current incoming connection.
_HttpIncoming _incoming;
- StreamSubscription<List<int>> _socketSubscription;
+ StreamSubscription _socketSubscription;
bool _paused = true;
bool _bodyPaused = false;
StreamController<_HttpIncoming> _controller;
« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | sdk/lib/io/io_resource_info.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698