Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 1974043002: Revert "Fix remaining strong-mode warnings and errors in dart:io." (Closed)

Created:
4 years, 7 months ago by floitsch
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix remaining strong-mode warnings and errors in dart:io." This reverts commit 493c70d2b02335b3344031451cdc2e2ccfae37da. Committed: https://github.com/dart-lang/sdk/commit/49fe254ea2b94a632d2707eed117c0783b07cc9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -154 lines) Patch
M sdk/lib/io/bytes_builder.dart View 1 chunk +4 lines, -7 lines 0 comments Download
M sdk/lib/io/common.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/crypto.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/io/data_transformer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/directory_impl.dart View 4 chunks +30 lines, -6 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 22 chunks +29 lines, -39 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M sdk/lib/io/io_resource_info.dart View 7 chunks +10 lines, -8 lines 0 comments Download
M sdk/lib/io/link.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/platform_impl.dart View 4 chunks +4 lines, -6 lines 0 comments Download
M sdk/lib/io/secure_socket.dart View 8 chunks +25 lines, -19 lines 0 comments Download
M sdk/lib/io/socket.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/io/stdio.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/websocket.dart View 3 chunks +8 lines, -11 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 16 chunks +27 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
Broke the windows build... :(
4 years, 7 months ago (2016-05-12 16:16:49 UTC) #2
floitsch
TBR.
4 years, 7 months ago (2016-05-12 16:16:57 UTC) #3
floitsch
4 years, 7 months ago (2016-05-12 16:17:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49fe254ea2b94a632d2707eed117c0783b07cc9d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698