Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 1974033004: (reland) cc: Refactor layer/tile manager unittest to extract common code. (Closed)

Created:
4 years, 7 months ago by vmpstr
Modified:
4 years, 7 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(reland) cc: Refactor layer/tile manager unittest to extract common code. This patch introduces a new test base that can be used to easily setup a layer tree host with some layers. This is already used in picture layer impl tests and in tile manager unit/perf tests. Now, we can also write new tests without copy/pasting this class. R=danakj, enne CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/631c144e32e27e9576053aa3cb046d8bc9780ffc Cr-Commit-Position: refs/heads/master@{#393658} Committed: https://crrev.com/6edf66ce4d9867223efd8ab3b95eddc30d87ed01 Cr-Commit-Position: refs/heads/master@{#394524}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : fix perftests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1563 lines, -1693 lines) Patch
M cc/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 149 chunks +985 lines, -1115 lines 0 comments Download
A cc/test/test_layer_tree_host_base.h View 1 chunk +83 lines, -0 lines 0 comments Download
A cc/test/test_layer_tree_host_base.cc View 1 chunk +180 lines, -0 lines 0 comments Download
M cc/tiles/tile_manager_perftest.cc View 1 2 3 10 chunks +41 lines, -124 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 1 2 62 chunks +270 lines, -454 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
vmpstr
Please take a look.
4 years, 7 months ago (2016-05-12 23:14:50 UTC) #2
enne (OOO)
lgtm
4 years, 7 months ago (2016-05-13 00:41:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974033004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974033004/20001
4 years, 7 months ago (2016-05-13 18:43:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/5261) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-13 18:46:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974033004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974033004/40001
4 years, 7 months ago (2016-05-13 20:45:55 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-13 22:05:19 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/631c144e32e27e9576053aa3cb046d8bc9780ffc Cr-Commit-Position: refs/heads/master@{#393658}
4 years, 7 months ago (2016-05-13 22:06:46 UTC) #13
Sami
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1988053002/ by skyostil@chromium.org. ...
4 years, 7 months ago (2016-05-18 10:26:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974033004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974033004/60001
4 years, 7 months ago (2016-05-18 18:15:32 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-18 20:12:33 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 20:14:15 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6edf66ce4d9867223efd8ab3b95eddc30d87ed01
Cr-Commit-Position: refs/heads/master@{#394524}

Powered by Google App Engine
This is Rietveld 408576698