Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.idl

Issue 1974033003: Ship the Notification.action and Notification.vibration properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@threadsafe-statics
Patch Set: Ship the Notification.action and Notification.vibration properties Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/notifications/Notification.idl
diff --git a/third_party/WebKit/Source/modules/notifications/Notification.idl b/third_party/WebKit/Source/modules/notifications/Notification.idl
index 03c304060debfd56ea7ebb49b9397bda04597612..5340c28f402f464bb1112427b55847b166b4f2bb 100644
--- a/third_party/WebKit/Source/modules/notifications/Notification.idl
+++ b/third_party/WebKit/Source/modules/notifications/Notification.idl
@@ -68,17 +68,13 @@ enum NotificationPermission {
readonly attribute USVString icon;
[RuntimeEnabled=NotificationBadge] readonly attribute USVString badge;
- [RuntimeEnabled=NotificationExperimental] readonly attribute sequence<unsigned long>? vibrate;
+ [SameObject, SaveSameObject] readonly attribute FrozenArray<unsigned long> vibrate;
readonly attribute DOMTimeStamp timestamp;
readonly attribute boolean renotify;
readonly attribute boolean silent;
readonly attribute boolean requireInteraction;
[CallWith=ScriptState, SameObject] readonly attribute any data;
-
- // TODO(johnme): Ship once Blink supports FrozenArray (https://crbug.com/515920)
- // and we've implemented the additional Object.freeze described in
- // https://notifications.spec.whatwg.org/#dom-notification-actions
- [RuntimeEnabled=NotificationExperimental] readonly attribute sequence<NotificationAction> actions;
+ [CallWith=ScriptState, SameObject, SaveSameObject] readonly attribute FrozenArray<NotificationAction> actions;
[MeasureAs=NotificationClosed] void close();
};

Powered by Google App Engine
This is Rietveld 408576698