third_party/WebKit/Source/modules/notifications/Notification.h - Issue 1974033003: Ship the Notification.action and Notification.vibration properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 1974033003: Ship the Notification.action and Notification.vibration properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@threadsafe-statics

Patch Set: Ship the Notification.action and Notification.vibration properties Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h ('k') | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/Notification.h

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.h b/third_party/WebKit/Source/modules/notifications/Notification.h

index 4d641660073c95e13cf4a295d5900ba0c16d186f..39b3c184cdba8dec1fd48a8043e56ddc7d13d367 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.h

+++ b/third_party/WebKit/Source/modules/notifications/Notification.h

@@ -92,13 +92,13 @@ public:

String tag() const;

String icon() const;

String badge() const;

- NavigatorVibration::VibrationPattern vibrate(bool& isNull) const;

+ NavigatorVibration::VibrationPattern vibrate() const;

DOMTimeStamp timestamp() const;

bool renotify() const;

bool silent() const;

bool requireInteraction() const;

ScriptValue data(ScriptState*);

- HeapVector<NotificationAction> actions() const;

+ Vector<v8::Local<v8::Value>> actions(ScriptState*) const;

static String permissionString(mojom::blink::PermissionStatus);

static String permission(ExecutionContext*);