Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html

Issue 1974033003: Ship the Notification.action and Notification.vibration properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@threadsafe-statics
Patch Set: Ship the Notification.action and Notification.vibration properties Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html b/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html
index 21a05bda7a9150d4378826624792a9725548a2e2..3a1fea7dae8125f0e4ae4aea4c57bc05250c33f6 100644
--- a/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html
+++ b/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html
@@ -96,15 +96,18 @@
assert_object_is_superset(notifications[0], options, 'The Notification object properties must be the same in getNotifications.');
notifications[0].actions.foo = 'bar';
- notifications[0].actions.push({ title: 'Foo' });
+ assert_throws(null, () => notifications[0].actions.push({ title: 'Foo' }));
+
if (notifications[0].actions.length) {
notifications[0].actions[0].title = 'Changed';
notifications[0].actions[0].foo = 'bar';
}
+
assert_object_equals(notifications[0].actions, options.actions, 'The actions field should be immutable.');
- // TODO(johnme): This should pass before shipping Notification.actions; this is blocked on https://crbug.com/515920.
- //assert_equals(notifications[0].actions, notifications[0].actions, 'The actions field should === itself.');
+ assert_equals(notifications[0].actions, notifications[0].actions, '`actions` attribute equality');
+ assert_equals(notifications[0].data, notifications[0].data, '`data` attribute equality');
+ assert_equals(notifications[0].vibrate, notifications[0].vibrate, '`vibrate` attribute equality');
test.done();
}).catch(unreached_rejection(test));

Powered by Google App Engine
This is Rietveld 408576698