Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1974023002: Remove base/thread_task_runner_handle.h dummy. (Closed)

Created:
4 years, 7 months ago by gab
Modified:
4 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, sadrul, chromoting-reviews_chromium.org, sievers+watch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, dimich+watch_chromium.org, maniscalco+watch-blimp_chromium.org, dewittj+watch_chromium.org, fgorski+watch_chromium.org, jam, jbauman+watch_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, kalyank, petewil+watch_chromium.org, piman+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, romax+watch_chromium.org, chili+watch_chromium.org, danakj+watch_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base/thread_task_runner_handle.h dummy. Plus a few more renames made by tools/git/move_source_file.py --already_moved for commits since yesterday. Everyone should now use base/threading/thread_task_runner_handle.h BUG=610438 TBR=danakj@chromium.org Committed: https://crrev.com/65aa436e147d91b85e53c95ec1557b8a9c23f2e4 Cr-Commit-Position: refs/heads/master@{#393256}

Patch Set 1 #

Patch Set 2 : rm duplicate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M ash/system/web_notification/web_notification_tray.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D base/thread_task_runner_handle.h View 1 chunk +0 lines, -11 lines 0 comments Download
M blimp/engine/app/blimp_metrics_service_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/background/request_coordinator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/proxy_resolving_client_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/communicator/single_login_attempt_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/non_blocking_push_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/non_blocking_push_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/client_telemetry_logger_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
gab
TBR danakj for removal of dummy base/thread_task_runner_handle.h and a few more scattered last minute renames. ...
4 years, 7 months ago (2016-05-12 14:22:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974023002/20001
4 years, 7 months ago (2016-05-12 14:22:57 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 15:40:57 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/65aa436e147d91b85e53c95ec1557b8a9c23f2e4 Cr-Commit-Position: refs/heads/master@{#393256}
4 years, 7 months ago (2016-05-12 15:42:14 UTC) #6
danakj
4 years, 7 months ago (2016-05-12 18:28:06 UTC) #7
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698