Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: components/image_fetcher/image_fetcher.h

Issue 1974013002: Replace SkBitmap with gfx::Image in the ImageFetcher API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync again Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search/thumbnail_source.cc ('k') | components/image_fetcher/image_fetcher_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/image_fetcher/image_fetcher.h
diff --git a/components/image_fetcher/image_fetcher.h b/components/image_fetcher/image_fetcher.h
index 04f417c66b68af0e11dbfb30a3ede7993d3dd50a..812067608fac8aadbeeef9e2b6ad0e1dbd6a163a 100644
--- a/components/image_fetcher/image_fetcher.h
+++ b/components/image_fetcher/image_fetcher.h
@@ -10,7 +10,9 @@
#include "components/image_fetcher/image_fetcher_delegate.h"
#include "url/gurl.h"
-class SkBitmap;
+namespace gfx {
+class Image;
+}
namespace image_fetcher {
@@ -23,10 +25,12 @@ class ImageFetcher {
virtual void SetImageFetcherDelegate(ImageFetcherDelegate* delegate) = 0;
+ // An empty gfx::Image will be returned to the callback in case the image
+ // could not be fetched.
virtual void StartOrQueueNetworkRequest(
const GURL& url,
const GURL& image_url,
- base::Callback<void(const GURL&, const SkBitmap*)> callback) = 0;
+ base::Callback<void(const GURL&, const gfx::Image&)> callback) = 0;
private:
DISALLOW_COPY_AND_ASSIGN(ImageFetcher);
« no previous file with comments | « chrome/browser/search/thumbnail_source.cc ('k') | components/image_fetcher/image_fetcher_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698