components/suggestions/image_manager_unittest.cc - Issue 1974013002: Replace SkBitmap with gfx::Image in the ImageFetcher API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/suggestions/image_manager_unittest.cc

Issue 1974013002: Replace SkBitmap with gfx::Image in the ImageFetcher API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from treib@ Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/suggestions/image_manager.cc ('k') | ios/chrome/browser/suggestions/image_fetcher_impl.h » ('j') | ios/chrome/browser/suggestions/image_fetcher_impl.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/suggestions/image_manager_unittest.cc

diff --git a/components/suggestions/image_manager_unittest.cc b/components/suggestions/image_manager_unittest.cc

index 28398c342689b304ee5431ecac1da24afc8082d2..a01d0630ba417fcacf42ad7a379753eb55cb936b 100644

--- a/components/suggestions/image_manager_unittest.cc

+++ b/components/suggestions/image_manager_unittest.cc

@@ -19,6 +19,7 @@

#include "components/suggestions/proto/suggestions.pb.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "ui/gfx/image/image.h"

#include "ui/gfx/image/image_skia.h"

#include "url/gurl.h"

@@ -48,7 +49,7 @@ class MockImageFetcher : public ImageFetcher {

virtual ~MockImageFetcher() {}

MOCK_METHOD3(StartOrQueueNetworkRequest,

void(const GURL&, const GURL&,

- base::Callback<void(const GURL&, const SkBitmap*)>));

+ base::Callback<void(const GURL&, const gfx::Image&)>));

MOCK_METHOD1(SetImageFetcherDelegate, void(ImageFetcherDelegate*));

};