Chromium Code Reviews| Index: ios/chrome/browser/suggestions/image_fetcher_impl.mm |
| diff --git a/ios/chrome/browser/suggestions/image_fetcher_impl.mm b/ios/chrome/browser/suggestions/image_fetcher_impl.mm |
| index 553f02cbb1fbd7c15b2c637ffd6d7667a73cdf9a..cd5e633daeedb406e2130b5684621ee988fe80c8 100644 |
| --- a/ios/chrome/browser/suggestions/image_fetcher_impl.mm |
| +++ b/ios/chrome/browser/suggestions/image_fetcher_impl.mm |
| @@ -11,6 +11,7 @@ |
| #include "ios/chrome/browser/net/image_fetcher.h" |
| #include "net/url_request/url_request_context_getter.h" |
| #include "skia/ext/skia_utils_ios.h" |
| +#include "ui/gfx/image/image.h" |
| namespace suggestions { |
| @@ -33,11 +34,12 @@ void ImageFetcherImpl::SetImageFetcherDelegate( |
| void ImageFetcherImpl::StartOrQueueNetworkRequest( |
| const GURL& url, |
| const GURL& image_url, |
| - base::Callback<void(const GURL&, const SkBitmap*)> callback) { |
| + base::Callback<void(const GURL&, const gfx::Image&)> callback) { |
| + gfx::Image empty_image; |
| if (image_url.is_empty()) { |
| - callback.Run(url, nullptr); |
| + callback.Run(url, empty_image); |
| if (delegate_) { |
| - delegate_->OnImageFetched(url, nullptr); |
| + delegate_->OnImageFetched(url, empty_image); |
| } |
| return; |
| } |
| @@ -47,20 +49,19 @@ void ImageFetcherImpl::StartOrQueueNetworkRequest( |
| ^(const GURL& original_url, int response_code, NSData* data) { |
| if (data) { |
| // Most likely always returns 1x images. |
| - UIImage* image = [UIImage imageWithData:data scale:1]; |
| - if (image) { |
| - SkBitmap bitmap = |
| - skia::CGImageToSkBitmap(image.CGImage, [image size], YES); |
| - callback.Run(page_url, &bitmap); |
| + UIImage* ui_image = [UIImage imageWithData:data scale:1]; |
| + if (ui_image) { |
| + gfx::Image image = gfx::Image(ui_image); |
|
Marc Treib
2016/05/17 14:12:01
nit: You could just write
gfx::Image image(ui_imag
markusheintz_
2016/05/17 14:26:45
Done.
|
| + callback.Run(page_url, image); |
| if (delegate_) { |
| - delegate_->OnImageFetched(page_url, &bitmap); |
| + delegate_->OnImageFetched(page_url, gfx_image); |
|
Marc Treib
2016/05/17 14:12:01
s/gfx_image/image/
markusheintz_
2016/05/17 14:26:45
Done.
|
| } |
| return; |
| } |
| } |
| - callback.Run(page_url, nullptr); |
| + callback.Run(page_url, empty_image); |
| if (delegate_) { |
| - delegate_->OnImageFetched(page_url, nullptr); |
| + delegate_->OnImageFetched(page_url, empty_image); |
| } |
| }; |
| imageFetcher_->StartDownload(image_url, fetcher_callback); |