Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: ios/chrome/browser/suggestions/image_fetcher_impl.h

Issue 1974013002: Replace SkBitmap with gfx::Image in the ImageFetcher API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix iOS build errors. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/suggestions/image_fetcher_impl.h
diff --git a/ios/chrome/browser/suggestions/image_fetcher_impl.h b/ios/chrome/browser/suggestions/image_fetcher_impl.h
index f7fe4dbaa92378c5a5f47e05df0ff16acecb1103..15f45cf1af9bd23f05b31fcde1b5f737a5df32bf 100644
--- a/ios/chrome/browser/suggestions/image_fetcher_impl.h
+++ b/ios/chrome/browser/suggestions/image_fetcher_impl.h
@@ -10,19 +10,19 @@
#include "base/callback_forward.h"
#include "base/macros.h"
#include "components/image_fetcher/image_fetcher.h"
+#include "ui/gfx/image/image.h"
Marc Treib 2016/05/13 15:54:00 nit: forward-declare; no need to include here
markusheintz_ 2016/05/17 13:08:23 Done.
class GURL;
class ImageFetcher;
-class SkBitmap;
-
-namespace image_fetcher {
-class ImageFetcherDelegate;
-}
namespace base {
class SequencedWorkerPool;
}
+namespace image_fetcher {
+class ImageFetcherDelegate;
+}
+
namespace net {
class URLRequestContextGetter;
}
@@ -42,7 +42,7 @@ class ImageFetcherImpl : public image_fetcher::ImageFetcher {
void StartOrQueueNetworkRequest(
const GURL& url,
const GURL& image_url,
- base::Callback<void(const GURL&, const SkBitmap*)> callback) override;
+ base::Callback<void(const GURL&, const gfx::Image&)> callback) override;
private:
std::unique_ptr<::ImageFetcher> imageFetcher_;

Powered by Google App Engine
This is Rietveld 408576698