components/ntp_snippets/BUILD.gn - Issue 1974013002: Replace SkBitmap with gfx::Image in the ImageFetcher API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/BUILD.gn

Issue 1974013002: Replace SkBitmap with gfx::Image in the ImageFetcher API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix iOS build errors. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/image_fetcher/image_fetcher_delegate.h ('K') | « components/image_fetcher/image_fetcher_delegate.h ('k') | components/ntp_snippets/DEPS » ('j') | components/ntp_snippets/ntp_snippets_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/BUILD.gn

diff --git a/components/ntp_snippets/BUILD.gn b/components/ntp_snippets/BUILD.gn

index 863f7bd00dbb35e9aa2baa31aa2625d0b079f471..cc91365d12be351caed88ccc81cd19b2b7c2e0f8 100644

--- a/components/ntp_snippets/BUILD.gn

+++ b/components/ntp_snippets/BUILD.gn

@@ -37,6 +37,7 @@ source_set("ntp_snippets") {

"//components/metrics",

"//components/variations",

"//third_party/icu/",

+ "//ui/gfx/",

Marc Treib 2016/05/13 15:54:00 Does the trailing slash do anything? Most of the d

markusheintz_ 2016/05/17 13:08:22 TBH I don't know. Removed the trailing slash

]

}