chrome/browser/search/thumbnail_source.h - Issue 1974013002: Replace SkBitmap with gfx::Image in the ImageFetcher API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/thumbnail_source.h

Issue 1974013002: Replace SkBitmap with gfx::Image in the ImageFetcher API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix iOS build errors. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc ('K') | « chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc ('k') | chrome/browser/search/thumbnail_source.cc » ('j') | components/image_fetcher/image_fetcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/thumbnail_source.h

diff --git a/chrome/browser/search/thumbnail_source.h b/chrome/browser/search/thumbnail_source.h

index 5e17f46d4108d523a8f925ca1cfda06fef95dc50..a65c59cc669e8bca2df44930c0ca0fec61cb59f3 100644

--- a/chrome/browser/search/thumbnail_source.h

+++ b/chrome/browser/search/thumbnail_source.h

@@ -12,6 +12,7 @@

#include "base/memory/ref_counted.h"

#include "base/memory/weak_ptr.h"

#include "content/public/browser/url_data_source.h"

+#include "ui/gfx/image/image.h"

Marc Treib 2016/05/13 15:53:59 nit: You can forward-declare this, no need to incl

markusheintz_ 2016/05/17 13:08:22 Done.

#include "url/gurl.h"

class Profile;

@@ -61,7 +62,7 @@ class ThumbnailSource : public content::URLDataSource {

void SendFetchedUrlImage(

const content::URLDataSource::GotDataCallback& callback,

const GURL& url,

- const SkBitmap* bitmap);

+ const gfx::Image& image);

// Raw PNG representation of the thumbnail to show when the thumbnail

// database doesn't have a thumbnail for a webpage.