Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1974003002: Add V8.Execute histogram to measure time spent executing JS code. (Closed)

Created:
4 years, 7 months ago by rmcilroy
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add V8.Execute histogram to measure time spent executing JS code. Adds a V8.Execute histogram to measure the amount of time spent executing JS code. BUG=v8:4865 LOG=N Committed: https://crrev.com/e8f5a2723cf54576b84322ac2ee6ef7abc9df056 Cr-Commit-Position: refs/heads/master@{#36217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -40 lines) Patch
M src/api.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M src/counters.h View 1 chunk +42 lines, -40 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974003002/1
4 years, 7 months ago (2016-05-12 14:02:55 UTC) #2
rmcilroy
Camillo, PTAL, thanks.
4 years, 7 months ago (2016-05-12 14:03:16 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 14:35:46 UTC) #6
Camillo Bruni
Ain't pretty but will do ;) LGTM
4 years, 7 months ago (2016-05-12 16:13:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974003002/1
4 years, 7 months ago (2016-05-12 16:59:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 17:12:19 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e8f5a2723cf54576b84322ac2ee6ef7abc9df056 Cr-Commit-Position: refs/heads/master@{#36217}
4 years, 7 months ago (2016-05-12 17:12:40 UTC) #12
Michael Hablich
4 years, 7 months ago (2016-05-13 11:16:22 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1970193003/ by hablich@chromium.org.

The reason for reverting is: Blocks roll
https://codereview.chromium.org/1972303002/

Repro:
- build chromium with this CL
- out/Default/content_browsertests
--gtest_filter=AccessibilityHitTestingBrowserTest.HitTestingInIframes.

Powered by Google App Engine
This is Rietveld 408576698