Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1973973004: [MD settings] remove unneeded use of I18nBehavior (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, dcheng, jlklein+watch-closure_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, vitalyp+closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] remove unneeded use of I18nBehavior This CL removes the import and behavior or I18nBehavior from files that don't use the this.i18n(). BUG=611188 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a Cr-Commit-Position: refs/heads/master@{#393711}

Patch Set 1 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -91 lines) Patch
M chrome/browser/resources/settings/advanced_page/advanced_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/advanced_page/advanced_page.js View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/resources/settings/advanced_page/compiled_resources2.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.js View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/compiled_resources2.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/compiled_resources2.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_dropdown_menu.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_dropdown_menu.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/default_browser_page/default_browser_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/default_browser_page/default_browser_page.js View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/compiled_resources2.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.js View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/camera.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/camera.js View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/compiled_resources2.gyp View 4 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/people_page/sync_page.html View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.js View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.js View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dschuyler
4 years, 7 months ago (2016-05-13 22:11:12 UTC) #4
dpapad
lgtm
4 years, 7 months ago (2016-05-13 22:18:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973973004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973973004/20001
4 years, 7 months ago (2016-05-14 00:43:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-14 00:50:37 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-14 00:53:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a
Cr-Commit-Position: refs/heads/master@{#393711}

Powered by Google App Engine
This is Rietveld 408576698