Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1973943002: Fix style in Credential Manager code (Closed)

Created:
4 years, 7 months ago by vabr (Chromium)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix style in Credential Manager code This CL addresses post-landing comments from https://codereview.chromium.org/1967693003/. R=yutak@chromium.org TBR=mkwst@chromium.org BUG=610646 Committed: https://crrev.com/e35fb1fb6c25186d0f3758d080fe2a2d48e77043 Cr-Commit-Position: refs/heads/master@{#393224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebCredential.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
vabr (Chromium)
yutak@ -- Thanks for your comments in https://codereview.chromium.org/1967693003/. Please find them addressed in this follow-up ...
4 years, 7 months ago (2016-05-12 08:42:14 UTC) #3
Yuta Kitamura
lgtm
4 years, 7 months ago (2016-05-12 08:49:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973943002/1
4 years, 7 months ago (2016-05-12 09:13:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 11:00:02 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e35fb1fb6c25186d0f3758d080fe2a2d48e77043 Cr-Commit-Position: refs/heads/master@{#393224}
4 years, 7 months ago (2016-05-12 11:01:25 UTC) #10
haraken
4 years, 7 months ago (2016-05-12 13:11:04 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698