Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 197393002: Add hooks for GL_EXT_debug_markers for Skia (Closed)

Created:
6 years, 9 months ago by egdaniel
Modified:
6 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add hooks for GL_EXT_debug_markers for Skia BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256911

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/generate_bindings.py View 3 chunks +9 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_skia_in_process.cc View 1 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
egdaniel
PTAL
6 years, 9 months ago (2014-03-12 13:50:34 UTC) #1
piman
lgtm https://codereview.chromium.org/197393002/diff/1/ui/gl/gl_bindings_skia_in_process.cc File ui/gl/gl_bindings_skia_in_process.cc (right): https://codereview.chromium.org/197393002/diff/1/ui/gl/gl_bindings_skia_in_process.cc#newcode350 ui/gl/gl_bindings_skia_in_process.cc:350: glInsertEventMarkerEXT(length, marker); nit: 2 space indent (same below). ...
6 years, 9 months ago (2014-03-13 00:29:22 UTC) #2
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 9 months ago (2014-03-13 13:32:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/egdaniel@google.com/197393002/1
6 years, 9 months ago (2014-03-13 13:32:31 UTC) #4
egdaniel
The CQ bit was unchecked by egdaniel@google.com
6 years, 9 months ago (2014-03-13 13:36:23 UTC) #5
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 9 months ago (2014-03-13 17:58:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/egdaniel@google.com/197393002/20001
6 years, 9 months ago (2014-03-13 18:00:46 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 20:19:17 UTC) #8
Message was sent while issue was closed.
Change committed as 256911

Powered by Google App Engine
This is Rietveld 408576698