Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1973883005: ReplaceSelections() methods never called. (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

ReplaceSelections() methods never called. Committed: https://pdfium.googlesource.com/pdfium/+/8adc153ea6fe778d19dc33cd2c5b87aed312b29b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M xfa/fwl/basewidget/fwl_editimp.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 2 chunks +0 lines, -16 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_edit.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_edit.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_edit.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, nothing but red.
4 years, 7 months ago (2016-05-13 21:14:59 UTC) #2
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-13 21:23:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973883005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973883005/1
4 years, 7 months ago (2016-05-13 21:25:43 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 22:19:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/8adc153ea6fe778d19dc33cd2c5b87aed312...

Powered by Google App Engine
This is Rietveld 408576698