Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1973883003: S390: [crankshaft] Fragmentation-free allocation folding. (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [crankshaft] Fragmentation-free allocation folding. Port 61f5fbbb1926e1ffb672214a043e8c98db0e8af6 Port 6e15433db4df53bdb6d7e84fb7eba544ef6097f3 Original commit message: The new allocation folding implementation avoids fragmentation between folded allocation. As a consequence, our heap will always be iterable i.e. we do not have to perform a garbage collection before iterating the heap. R=hpayer@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/41dbaefb4a26ee01fc9e799da33b42fc5159ae01 Cr-Commit-Position: refs/heads/master@{#36243}

Patch Set 1 #

Patch Set 2 : pull in 6e15433db4df53bdb6d7e84fb7eba544ef6097f3 #

Patch Set 3 : run git cl format #

Total comments: 2

Patch Set 4 : use kNear more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -7 lines) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 2 2 chunks +49 lines, -0 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.h View 2 chunks +17 lines, -0 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 2 3 6 chunks +113 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
john.yan
PTAL
4 years, 7 months ago (2016-05-12 23:25:06 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973883003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973883003/40001
4 years, 7 months ago (2016-05-12 23:25:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 23:56:35 UTC) #6
JoranSiu
Minor nits, but lgtm otherwise. https://codereview.chromium.org/1973883003/diff/40001/src/s390/macro-assembler-s390.cc File src/s390/macro-assembler-s390.cc (right): https://codereview.chromium.org/1973883003/diff/40001/src/s390/macro-assembler-s390.cc#newcode1933 src/s390/macro-assembler-s390.cc:1933: beq(&aligned); CAn you add ...
4 years, 7 months ago (2016-05-13 00:53:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973883003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973883003/60001
4 years, 7 months ago (2016-05-13 13:21:19 UTC) #10
john.yan
On 2016/05/13 00:53:59, JoranSiu wrote: > Minor nits, but lgtm otherwise. > > https://codereview.chromium.org/1973883003/diff/40001/src/s390/macro-assembler-s390.cc > ...
4 years, 7 months ago (2016-05-13 13:22:09 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-13 13:44:19 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 13:44:59 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/41dbaefb4a26ee01fc9e799da33b42fc5159ae01
Cr-Commit-Position: refs/heads/master@{#36243}

Powered by Google App Engine
This is Rietveld 408576698