[Interpreter] Make Fast-paths of StackCheck, Jump Return, ForInNext not build a frame.

[Interpreter] Make Fast-paths of StackCheck, Jump Return, ForInNext not build a frame.

Tweaks the generated code for a number of bytecode handlers. In particular, uses
deferred labels (now that they exist) to ensure that fast-paths don't build frames
where possible. This improves the codegen for StackCheck, Jump, Return and ForInNext.
Also tweak the codegen for CreateArguments, LogicalNot, ForInDone.

Seems to give ~5-8% performance boost on Octane.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/40c787288d3b45ec8b477bc0c8bba4216e625d95
Cr-Commit-Position: refs/heads/master@{#36236}

[rmcilroy, 2016-05-13 09:42:28]

Description was changed from

==========
[Interpreter] Make Fast-paths of StackCheck, Jump Return, ForInNext not build a
frame.

Tweaks the generated code for a number of bytecode handlers. In particular, uses
deferred labels (now that they exist) to ensure that fast-paths don't build
frames
where possible. This improves the codegen for StackCheck, Jump and Return. Also
tweak the codegen for CreateArguments, LogicalNot, ForInDone and ForInNext.

Seems to give ~5-8% performance boost on Octane.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Make Fast-paths of StackCheck, Jump Return, ForInNext not build a
frame.

Tweaks the generated code for a number of bytecode handlers. In particular, uses
deferred labels (now that they exist) to ensure that fast-paths don't build
frames
where possible. This improves the codegen for StackCheck, Jump, Return and
ForInNext. Also
tweak the codegen for CreateArguments, LogicalNot, ForInDone.

Seems to give ~5-8% performance boost on Octane.

BUG=v8:4280
LOG=N
==========

[rmcilroy, 2016-05-13 09:42:44]

Description was changed from

==========
[Interpreter] Make Fast-paths of StackCheck, Jump Return, ForInNext not build a
frame.

Tweaks the generated code for a number of bytecode handlers. In particular, uses
deferred labels (now that they exist) to ensure that fast-paths don't build
frames
where possible. This improves the codegen for StackCheck, Jump, Return and
ForInNext. Also
tweak the codegen for CreateArguments, LogicalNot, ForInDone.

Seems to give ~5-8% performance boost on Octane.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Make Fast-paths of StackCheck, Jump Return, ForInNext not build a
frame.

Tweaks the generated code for a number of bytecode handlers. In particular, uses
deferred labels (now that they exist) to ensure that fast-paths don't build
frames
where possible. This improves the codegen for StackCheck, Jump, Return and
ForInNext.
Also tweak the codegen for CreateArguments, LogicalNot, ForInDone.

Seems to give ~5-8% performance boost on Octane.

BUG=v8:4280
LOG=N
==========

[rmcilroy, 2016-05-13 09:44:27]

rmcilroy@chromium.org changed reviewers:
+ bmeurer@chromium.org, oth@chromium.org

[rmcilroy, 2016-05-13 09:44:28]

Benedikt, please review one-line change in compiler.
Orion, pleaser review interpreter changes.

Thanks.

[Benedikt Meurer, 2016-05-13 09:45:37]

Nice catch, awesome. LGTM.

[oth, 2016-05-13 10:34:27]

LGTM, +1 awesome :-D

[rmcilroy, 2016-05-13 10:42:32]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-05-13 10:42:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973873004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973873004/1

[commit-bot: I haz the power, 2016-05-13 10:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 10:43:52]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/5724)
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/5738)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/5713)

[rmcilroy, 2016-05-13 11:13:26]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-05-13 11:13:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, oth@chromium.org
Link to the patchset: https://codereview.chromium.org/1973873004/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-05-13 11:13:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973873004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973873004/20001

[commit-bot: I haz the power, 2016-05-13 11:44:41]

Description was changed from

==========
[Interpreter] Make Fast-paths of StackCheck, Jump Return, ForInNext not build a
frame.

Tweaks the generated code for a number of bytecode handlers. In particular, uses
deferred labels (now that they exist) to ensure that fast-paths don't build
frames
where possible. This improves the codegen for StackCheck, Jump, Return and
ForInNext.
Also tweak the codegen for CreateArguments, LogicalNot, ForInDone.

Seems to give ~5-8% performance boost on Octane.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Make Fast-paths of StackCheck, Jump Return, ForInNext not build a
frame.

Tweaks the generated code for a number of bytecode handlers. In particular, uses
deferred labels (now that they exist) to ensure that fast-paths don't build
frames
where possible. This improves the codegen for StackCheck, Jump, Return and
ForInNext.
Also tweak the codegen for CreateArguments, LogicalNot, ForInDone.

Seems to give ~5-8% performance boost on Octane.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2016-05-13 11:44:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-13 11:45:14]

Description was changed from

==========
[Interpreter] Make Fast-paths of StackCheck, Jump Return, ForInNext not build a
frame.

Tweaks the generated code for a number of bytecode handlers. In particular, uses
deferred labels (now that they exist) to ensure that fast-paths don't build
frames
where possible. This improves the codegen for StackCheck, Jump, Return and
ForInNext.
Also tweak the codegen for CreateArguments, LogicalNot, ForInDone.

Seems to give ~5-8% performance boost on Octane.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Make Fast-paths of StackCheck, Jump Return, ForInNext not build a
frame.

Tweaks the generated code for a number of bytecode handlers. In particular, uses
deferred labels (now that they exist) to ensure that fast-paths don't build
frames
where possible. This improves the codegen for StackCheck, Jump, Return and
ForInNext.
Also tweak the codegen for CreateArguments, LogicalNot, ForInDone.

Seems to give ~5-8% performance boost on Octane.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/40c787288d3b45ec8b477bc0c8bba4216e625d95
Cr-Commit-Position: refs/heads/master@{#36236}
==========

[commit-bot: I haz the power, 2016-05-13 11:45:15]

Patchset 2 (id:??) landed as
https://crrev.com/40c787288d3b45ec8b477bc0c8bba4216e625d95
Cr-Commit-Position: refs/heads/master@{#36236}