Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: components/autofill/core/browser/contact_info.h

Issue 1973873002: [Autofill] Improve the merging of two profiles' names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/contact_info.h
diff --git a/components/autofill/core/browser/contact_info.h b/components/autofill/core/browser/contact_info.h
index d2e70ba13f323e51b61923def7eed41eec7b8b50..1891eb7c5b196321b83a5d0cf25436240955d31c 100644
--- a/components/autofill/core/browser/contact_info.h
+++ b/components/autofill/core/browser/contact_info.h
@@ -26,6 +26,13 @@ class NameInfo : public FormGroup {
// The comparison is case sensitive.
bool ParsedNamesAreEqual(const NameInfo& info) const;
+ // Overwrites |this| NameInfo parts with the |new_name| parts if they have
+ // more information.
Mathieu 2016/05/13 13:32:51 // For every non-empty NameInfo part in |new_name|
sebsg 2016/05/13 17:20:02 Done.
+ void OverwriteName(const NameInfo& new_name);
+
+ // Returns true if all the name parts (first, middle and last) are empty.
+ bool NamePartsAreEmpty() const;
+
// FormGroup:
base::string16 GetRawInfo(ServerFieldType type) const override;
void SetRawInfo(ServerFieldType type, const base::string16& value) override;

Powered by Google App Engine
This is Rietveld 408576698