[Autofill] Improve the merging of two profiles' names.

components/autofill/core/browser/personal_data_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 3993 matching lines @@
     // For tests with profile merging, makes sure that these fields' values are
     // the ones we expect (depending on the test).
     ProfileFields changed_field_values;
   } TestCase;
 
   TestCase test_cases[] = {
       // Test that saving an identical profile except for the name results in
       // two profiles being saved.
       {ProfileFields(), {{NAME_FIRST, "Marionette"}}},
 
+      // Test that saving an identical profile except with the middle name
+      // initial instead of the full middle name results in the profiles
+      // getting merged and the full middle name being kept.
+      {ProfileFields(), {{NAME_MIDDLE, "M"}}, {{NAME_MIDDLE, "Mitchell"}}},
+
+      // Test that saving an identical profile except with the full middle name
+      // instead of the middle name initial results in the profiles getting
+      // merged and the full middle name replacing the initial.
+      {{{NAME_MIDDLE, "M"}},
+       {{NAME_MIDDLE, "Mitchell"}},
+       {{NAME_MIDDLE, "Mitchell"}}},
+
+      // Test that saving an identical profile except with no middle name
+      // results in the profiles getting merged and the full middle name being
+      // kept.
+      {ProfileFields(), {{NAME_MIDDLE, ""}}, {{NAME_MIDDLE, "Mitchell"}}},
+
+      // Test that saving an identical profile except with a middle name initial
+      // results in the profiles getting merged and the middle name initial
+      // being saved.
+      {{{NAME_MIDDLE, ""}}, {{NAME_MIDDLE, "M"}}, {{NAME_MIDDLE, "M"}}},
+
+      // Test that saving an identical profile except with a middle name
+      // results in the profiles getting merged and the full middle name being
+      // saved.
+      {{{NAME_MIDDLE, ""}},
+       {{NAME_MIDDLE, "Mitchell"}},
+       {{NAME_MIDDLE, "Mitchell"}}},
+
+      // Test that saving a identical profile except with the full name set
+      // instead of the name parts results in the two profiles being merged and
+      // all the name parts kept and the full name being added.
+      {
+          {
+              {NAME_FIRST, "Marion"},
+              {NAME_MIDDLE, "Mitchell"},
+              {NAME_LAST, "Morrison"},
+              {NAME_FULL, ""},
+          },
+          {
+              {NAME_FIRST, ""},
+              {NAME_MIDDLE, ""},
+              {NAME_LAST, ""},
+              {NAME_FULL, "Marion Mitchell Morrison"},
+          },
+          {
+              {NAME_FIRST, "Marion"},
+              {NAME_MIDDLE, "Mitchell"},
+              {NAME_LAST, "Morrison"},
+              {NAME_FULL, "Marion Mitchell Morrison"},
+          },
+      },
+
+      // Test that saving a identical profile except with the name parts set

[Mathieu, 2016/05/13 13:32:52]

Can we add a test where it's clear that the full name != name parts? Like "John"
"M" "Smith" "" and "" "" "" "Marion Mitchell Morisson". These would be merged
under the new rules, right? Worth putting a TODO so that it's documented that
it's not ideal.

[sebsg, 2016/05/13 17:20:02]

Done.

+      // instead of the full name results in the two profiles being merged and
+      // the full name being kept and all the name parts being added.
+      {
+          {
+              {NAME_FIRST, ""},
+              {NAME_MIDDLE, ""},
+              {NAME_LAST, ""},
+              {NAME_FULL, "Marion Mitchell Morrison"},
+          },
+          {
+              {NAME_FIRST, "Marion"},
+              {NAME_MIDDLE, "Mitchell"},
+              {NAME_LAST, "Morrison"},
+              {NAME_FULL, ""},
+          },
+          {
+              {NAME_FIRST, "Marion"},
+              {NAME_MIDDLE, "Mitchell"},
+              {NAME_LAST, "Morrison"},
+              {NAME_FULL, "Marion Mitchell Morrison"},
+          },
+      },
+
       // Test that saving an identical profile except for the first address line
       // results in two profiles being saved.
       {ProfileFields(), {{ADDRESS_HOME_LINE1, "123 Aquarium St."}}},
 
       // Test that saving an identical profile except for the second address
       // line results in two profiles being saved.
       {ProfileFields(), {{ADDRESS_HOME_LINE2, "unit 7"}}},
 
       // Tests that saving an identical profile that has a new piece of
       // information (company name) results in a merge and that the original
@@ skipping 121 matching lines @@
     personal_data_->SaveImportedProfile(profile2);
 
     const std::vector<AutofillProfile*>& saved_profiles =
         personal_data_->GetProfiles();
 
     // If there are no merge changes to verify, make sure that two profiles were
     // saved.
     if (test_case.changed_field_values.empty()) {
       EXPECT_EQ(2U, saved_profiles.size());
     } else {
+      EXPECT_EQ(1U, saved_profiles.size());
+
       // Make sure the new information was merged correctly.
       for (ProfileField changed_field : test_case.changed_field_values) {
         EXPECT_EQ(base::UTF8ToUTF16(changed_field.field_value),
                   saved_profiles.front()->GetRawInfo(changed_field.field_type));
       }
       // Verify that the merged profile's use count, use date and modification
       // date were updated.
       EXPECT_EQ(2U, saved_profiles.front()->use_count());
       EXPECT_GT(base::TimeDelta::FromMilliseconds(500),
                 base::Time::Now() - saved_profiles.front()->use_date());
@@ skipping 80 matching lines @@
   EXPECT_EQ(5U, profile.use_count());
   // The use date and modification dates should have been set to less than 500
   // milliseconds ago.
   EXPECT_GT(base::TimeDelta::FromMilliseconds(500),
             base::Time::Now() - profile.use_date());
   EXPECT_GT(base::TimeDelta::FromMilliseconds(500),
             base::Time::Now() - profile.modification_date());
 }
 
 }  // namespace autofill