[Autofill] Improve the merging of two profiles' names.

components/autofill/core/browser/autofill_profile_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_profile.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 1176 matching lines @@
 
   EXPECT_TRUE(a.SaveAdditionalInfo(b, "en-US"));
 
   EXPECT_EQ(base::ASCIIToUTF16("Marion"), a.GetRawInfo(NAME_FIRST));
   EXPECT_EQ(base::ASCIIToUTF16("Mitchell"), a.GetRawInfo(NAME_MIDDLE));
   EXPECT_EQ(base::ASCIIToUTF16("Morrison"), a.GetRawInfo(NAME_LAST));
   EXPECT_EQ(base::ASCIIToUTF16("Marion Mitchell Morrison"),
             a.GetRawInfo(NAME_FULL));
 }
 
-// TODO(crbug.com/608074): No loss of information for names should happen when
-// using SaveAddtitionalInfo.
-// Tests the merging of two similar profiles results the second profile's non-
-// empty fields overwriting the initial profiles values.
+// Tests the merging of two similar profiles results in the second profile's
+// non-empty fields overwriting the initial profiles values.
 TEST(AutofillProfileTest, SaveAdditionalInfo_Name_DifferentCaseNoNameFull) {

[Mathieu, 2016/05/13 13:32:51]

Do we have cases where one of the middle names is empty?

[sebsg, 2016/05/13 17:20:01]

Yes, in PersonalDataManagerTest.SaveImportedProfile

   AutofillProfile a;
 
   a.SetRawInfo(NAME_FIRST, base::ASCIIToUTF16("marion"));
   a.SetRawInfo(NAME_MIDDLE, base::ASCIIToUTF16("mitchell"));
   a.SetRawInfo(NAME_LAST, base::ASCIIToUTF16("morrison"));
-  a.SetRawInfo(NAME_FULL, base::ASCIIToUTF16("Marion Mitchell Morrison"));
+  a.SetRawInfo(NAME_FULL, base::ASCIIToUTF16("marion mitchell morrison"));
 
   AutofillProfile b = a;
   b.SetRawInfo(NAME_FIRST, base::ASCIIToUTF16("Marion"));
   b.SetRawInfo(NAME_MIDDLE, base::ASCIIToUTF16("Mitchell"));
   b.SetRawInfo(NAME_LAST, base::ASCIIToUTF16("Morrison"));
   b.SetRawInfo(NAME_FULL, base::ASCIIToUTF16(""));
 
   EXPECT_TRUE(a.SaveAdditionalInfo(b, "en-US"));
 
   // The first, middle and last names should have their first letter in
   // uppercase.
-  EXPECT_EQ(base::ASCIIToUTF16("marion"), a.GetRawInfo(NAME_FIRST));
-  EXPECT_EQ(base::ASCIIToUTF16("mitchell"), a.GetRawInfo(NAME_MIDDLE));
-  EXPECT_EQ(base::ASCIIToUTF16("morrison"), a.GetRawInfo(NAME_LAST));
-  EXPECT_EQ(base::ASCIIToUTF16("Marion Mitchell Morrison"),
+  EXPECT_EQ(base::ASCIIToUTF16("Marion"), a.GetRawInfo(NAME_FIRST));
+  EXPECT_EQ(base::ASCIIToUTF16("Mitchell"), a.GetRawInfo(NAME_MIDDLE));
+  EXPECT_EQ(base::ASCIIToUTF16("Morrison"), a.GetRawInfo(NAME_LAST));
+  EXPECT_EQ(base::ASCIIToUTF16("marion mitchell morrison"),
             a.GetRawInfo(NAME_FULL));
 }
 
-// TODO(crbug.com/608074): No loss of information for names should happen when
-// using SaveAddtitionalInfo.
 // Tests that no loss of information happens when SavingAdditionalInfo with a
 // profile with an empty name part.
 TEST(AutofillProfileTest, SaveAdditionalInfo_Name_LossOfInformation) {
   AutofillProfile a;
 
   a.SetRawInfo(NAME_FIRST, base::ASCIIToUTF16("Marion"));
   a.SetRawInfo(NAME_MIDDLE, base::ASCIIToUTF16("Mitchell"));
   a.SetRawInfo(NAME_LAST, base::ASCIIToUTF16("Morrison"));
 
   AutofillProfile b = a;
   b.SetRawInfo(NAME_MIDDLE, base::ASCIIToUTF16(""));
 
   EXPECT_TRUE(a.SaveAdditionalInfo(b, "en-US"));
 
   EXPECT_EQ(base::ASCIIToUTF16("Marion"), a.GetRawInfo(NAME_FIRST));
-  // This should not be empty.
-  EXPECT_EQ(base::ASCIIToUTF16(""), a.GetRawInfo(NAME_MIDDLE));
+  EXPECT_EQ(base::ASCIIToUTF16("Mitchell"), a.GetRawInfo(NAME_MIDDLE));
   EXPECT_EQ(base::ASCIIToUTF16("Morrison"), a.GetRawInfo(NAME_LAST));
-  EXPECT_EQ(base::ASCIIToUTF16(""), a.GetRawInfo(NAME_FULL));
 }
 
-// TODO(crbug.com/608074): No loss of information for names should happen when
-// using SaveAddtitionalInfo.
 // Tests that merging two complementary profiles for names results in a profile
 // with a complete name.
 TEST(AutofillProfileTest, SaveAdditionalInfo_Name_ComplementaryInformation) {
   AutofillProfile a;
 
   a.SetRawInfo(NAME_FIRST, base::ASCIIToUTF16("Marion"));
   a.SetRawInfo(NAME_MIDDLE, base::ASCIIToUTF16("Mitchell"));
   a.SetRawInfo(NAME_LAST, base::ASCIIToUTF16("Morrison"));
 
   AutofillProfile b;
   b.SetRawInfo(NAME_FULL, base::ASCIIToUTF16("Marion Mitchell Morrison"));
 
   EXPECT_TRUE(a.SaveAdditionalInfo(b, "en-US"));
 
-  // The first, middle and last names should be kept.
-  EXPECT_EQ(base::ASCIIToUTF16(""), a.GetRawInfo(NAME_FIRST));
-  EXPECT_EQ(base::ASCIIToUTF16(""), a.GetRawInfo(NAME_MIDDLE));
-  EXPECT_EQ(base::ASCIIToUTF16(""), a.GetRawInfo(NAME_LAST));
+  // The first, middle and last names should be kept and name full should be
+  // added.
+  EXPECT_EQ(base::ASCIIToUTF16("Marion"), a.GetRawInfo(NAME_FIRST));
+  EXPECT_EQ(base::ASCIIToUTF16("Mitchell"), a.GetRawInfo(NAME_MIDDLE));
+  EXPECT_EQ(base::ASCIIToUTF16("Morrison"), a.GetRawInfo(NAME_LAST));
   EXPECT_EQ(base::ASCIIToUTF16("Marion Mitchell Morrison"),
             a.GetRawInfo(NAME_FULL));
 }
 
 }  // namespace autofill