Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1973863005: media: Fix gn deps on media/gpu/* targets (Closed)

Created:
4 years, 7 months ago by jrummell
Modified:
4 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix gn deps on media/gpu/* targets Add an missing dependency. BUG=599578 TEST=gn check //media/gpu/* is clean Committed: https://crrev.com/5abb1019976cd9c7e4a62fae9d61a06856388304 Cr-Commit-Position: refs/heads/master@{#393405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/gpu/ipc/client/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jrummell
PTAL.
4 years, 7 months ago (2016-05-12 19:00:01 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 7 months ago (2016-05-13 00:03:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973863005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973863005/1
4 years, 7 months ago (2016-05-13 00:16:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 00:20:20 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 00:21:42 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5abb1019976cd9c7e4a62fae9d61a06856388304
Cr-Commit-Position: refs/heads/master@{#393405}

Powered by Google App Engine
This is Rietveld 408576698